Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model measurements #342

Merged
merged 18 commits into from
Aug 18, 2020
Merged

Model measurements #342

merged 18 commits into from
Aug 18, 2020

Conversation

goodb
Copy link
Contributor

@goodb goodb commented Aug 17, 2020

upgrade to owl api 4.5.15 from 4.5.13
Add gocam stat calculation to command line validation.

goodb added 16 commits July 24, 2020 16:52
In particular, started on some graph oriented metrics.
This cures some problems with reading owl ontologies out of RDF via the Rio library.  On a small fraction of models, notably those that imported go-lego-reacto.owl , the title for the model would not make it into the OWLOntology annotations.  Switching to 4.5.15 fixed this in all cases tested.
the information will just show up in the tab-delimited output file previously containing just the shex and owl result for each gocam.
This way we can compute on gpad if we want to without reading it out as a string.  Just used at the moment for getting row count for stats.
fixBrokenObjectPropertiesAndAxioms alleviates problems with object properties being read in as annotation properties.  It uses the RO namespace to guess what should be an object property and what should not.  With the OWL-API update, this may not be useful anymore.  Also added a simple test to see if a gocam has the go-lego import statement.
Also made more things just on be default to reduce parameter explosion.
@kltm
Copy link
Member

kltm commented Aug 17, 2020

@goodb Good to go to dev? Is there something you want you to demonstrate here soon?

leaving the gocam instance ontology alone, but replacing the term with its replacement for calculating stats.
@goodb
Copy link
Contributor Author

goodb commented Aug 17, 2020

@kltm lets let the changes I just pushed weave through travis test before merging.

Right now, the only impact of these changes should be on the command line validation routine. (Though the owl api upgrade likely cures some other unknown weirdnesses like the one that was killing me last week.) It will produce a much more detailed report about the model collection that it is fed. I'm using this to prepare information for the reactome paper but I believe it is generally useful for batch understanding of model collections.

@kltm
Copy link
Member

kltm commented Aug 17, 2020

@goodb Taking a quick look at all the changes, I was wondering if one of them was the proposed (#335 (comment)) fix for model-state?

@goodb
Copy link
Contributor Author

goodb commented Aug 17, 2020

Yes, the important change for that issue (as shown in #341 ) is in there.

@kltm
Copy link
Member

kltm commented Aug 18, 2020

@goodb If there is nothing more here, I'll merge. Would there be any issue with this going into master, anything that might affect the API? I'd ideally like to get this through to master to get the fix out in the pipeline for the model-state issue.

@goodb goodb merged commit e5429eb into dev Aug 18, 2020
@goodb
Copy link
Contributor Author

goodb commented Aug 18, 2020

@kltm I think it ought to be fine. Lets cycle dev and give it a quick manual check there first though, okay ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants