New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unverified HTTPS request warning #99

Open

href opened this issue Sep 18, 2017 · 1 comment

href commented Sep 18, 2017

When running various Gengo api calls, a warning pops up:

InsecureRequestWarning: Unverified HTTPS request is being made. Adding certificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.html#ssl-warnings

I think it would be a good idea for Gengo to verify certificates.

Author

href commented Feb 20, 2018

Is it possible to get this fixed? It's basically this statement that needs to be changed:

gengo-python/gengo/gengo.py

Lines 378 to 382 in 7364afd

 return req_method(base + '?{0}'.format(query_string), 

 headers=self.headers, 

 # Don't know why but requests is trying to verify 

 # SSL here ... 

 verify=False)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment