Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove captcha on examples #103

Merged
merged 2 commits into from
May 17, 2019
Merged

Remove captcha on examples #103

merged 2 commits into from
May 17, 2019

Conversation

ryvasquez
Copy link
Contributor

Description

  • Remove captcha examples, it will be no longer need when rejecting a job

perseusl
perseusl previously approved these changes May 16, 2019
View reviewed changes
Copy link

@perseusl perseusl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just the outdated branch 👍

josephniel
josephniel previously approved these changes May 17, 2019
View reviewed changes
narusemotoki
narusemotoki previously approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@narusemotoki narusemotoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
You don't bump version number because we don't need to release?

@ryvasquez ryvasquez dismissed stale reviews from narusemotoki, josephniel, and perseusl via e6e4a93 May 17, 2019 03:47
@ryvasquez
Copy link
Contributor Author

@jeanklingler @josephniel @narusemotoki PTAL

@jeanklingler
Copy link

you should probably rebase and double check the CI 🙂

@ryvasquez
Copy link
Contributor Author

@jeanklingler sure I will rebase, however the error in CI only occurring in python3.3

"pyflakes" failed during execution due to "'str' object has no attribute 'arg'"
Run flake8 with greater verbosity to see more details

@ryvasquez ryvasquez force-pushed the 166052278-remove-captcha-validation branch from e6e4a93 to c788771 Compare May 17, 2019 04:36
@ryvasquez ryvasquez force-pushed the 166052278-remove-captcha-validation branch from c788771 to c7950d1 Compare May 17, 2019 06:31
@ryvasquez ryvasquez marked this pull request as ready for review May 17, 2019 06:33
narusemotoki
narusemotoki approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@narusemotoki narusemotoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gengo.py is changed. Good to change the version number.

@ryvasquez
Copy link
Contributor Author

ryvasquez commented May 17, 2019 •
edited
Loading

@narusemotoki im not sure if its necessary, we dont change any implementation of behavior. maybe its not needed for this change. also I will release the 1.1.0 after this PR is merged from this PR #104

@ryvasquez ryvasquez merged commit ea145d3 into master May 17, 2019
@ryvasquez ryvasquez deleted the 166052278-remove-captcha-validation branch May 17, 2019 06:51
@narusemotoki
Copy link
Contributor

narusemotoki commented May 17, 2019 •
edited
Loading

But otherwise we can't upload this library to PyPI because version is conflicting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanklingler jeanklingler jeanklingler left review comments

@narusemotoki narusemotoki narusemotoki approved these changes

@carmisancha carmisancha carmisancha approved these changes

@perseusl perseusl perseusl left review comments

@josephniel josephniel josephniel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ryvasquez @jeanklingler @narusemotoki @perseusl @josephniel @carmisancha