This repository has been archived by the owner on Apr 16, 2023. It is now read-only.
Feature/sane defaults #884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
das-g
reviewed
Dec 15, 2017
Makefile
Outdated
| compose-env/common.env: compose-env-dist/common.env | ||
| @mkdir -p $(@D) | ||
| sed -e 's/^\(DJANGO_OSMAXX_CONVERSION_SERVICE_\(USERNAME\|PASSWORD\)=\)/\1dev/' < $< > $@ | ||
|
|
||
| PUBLIC_LOCALHOST_IP := $(shell ip route get 1 | awk '{print $$NF;exit}') |
There was a problem hiding this comment.
Seems like PUBLIC_LOCALHOST_IP isn't used anymore. If so, let's remove it, too.
There was a problem hiding this comment.
Good catch!
I did find an issue, that conversion_job.callback_url is pointing to localhost:8888 which is probably caused by not using this setting anymore. Since this varies between developer machines, I'm not sure how we should handle this. I have a proposal I'll push shortly.
|
Yes, that is a good proposal. Will push changes. |
das-g
approved these changes
Dec 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.