-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer to upgrade tests to support a higher version of react-redux #10127
Comments
fkellner
changed the title
Upgrade Tests to support a higher version of react-redux
Offer to upgrade tests to support a higher version of react-redux
Mar 28, 2024
fkellner
pushed a commit
to fkellner/MapStore2
that referenced
this issue
Apr 2, 2024
…ething to enable react-redux 7.x upwards On Behalf of DB Systel
fkellner
pushed a commit
to fkellner/MapStore2
that referenced
this issue
Apr 2, 2024
Updates tests relying on 'render' returning a reference to enable react-redux 7.x upwards (where some components become stateless and render no longer returns a reference, even though it was successful) On Behalf of DB Systel
2 tasks
2 tasks
tdipisa
added
the
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
label
Apr 4, 2024
tdipisa
removed
the
BackportNeeded
Commits provided for an issue need to be backported to the milestone's stable branch
label
Aug 30, 2024
offtherailz
pushed a commit
that referenced
this issue
Oct 18, 2024
Updates tests relying on 'render' returning a reference to enable react-redux 7.x upwards (where some components become stateless and render no longer returns a reference, even though it was successful) On Behalf of DB Systel Co-authored-by: Florian Kellner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
In our version of MapStore, we are currently using a newer version of
react-redux
, i.e.7.1.3
instead of6.0.0
, because it has a much cleaner syntax.However, this breaks tests, because of the
render
-function fromreact-dom
, which is frequently being used like this:render
does not return anything for stateless components:And apparently, by upgrading to
react-redux 7.x
, some components become stateless.A first step to enable you to upgrade to
react-redux 7.x
and enable us to keep using it would be to rewrite such tests like this:Would you accept a pull request with these changes to the tests?
This does not break compatibility with your current
react-redux
version and might also help with upgrading the tests once you reachReact 18 (where
render
is deprecated entirely).What kind of improvement you want to add? (check one with "x", remove the others)
Other useful information
This concerns the tests for
The text was updated successfully, but these errors were encountered: