Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with WFS added via Query params #10193

Closed
1 task done
mahmoudadel54 opened this issue Apr 12, 2024 · 0 comments · Fixed by #10195 or #10296
Closed
1 task done

Issue with WFS added via Query params #10193

mahmoudadel54 opened this issue Apr 12, 2024 · 0 comments · Fixed by #10195 or #10296

Comments

@mahmoudadel54
Copy link
Contributor

Description

Loading this URL:
http://localhost:8081/?debug=true/#/viewer/new?actions=%5B%7B%22type%22%3A%22CATALOG%3AADD_LAYERS_FROM_CATALOGS%22%2C%22layers%22%3A%5B%22geosolutions%3Astates_training%22%5D%2C%22sources%22%3A%5B%7B%22type%22%3A%22wfs%22%2C%22url%22%3A%22https%3A%2F%2Fgs-stable.geosolutionsgroup.com%2Fgeoserver%2Fwfs%3Frequest%3DGetCapabilities%26service%3DWFS%22%7D%5D%7D%5D

the WFS layer is added to the map but the layer is not visible: no GetFeature request performed by MS

Expected Result
WFS layer should be added to map and TOC and be visible + GetFeature request should be performed by MS normally.

Current Result
if the URL includes queryString, the layer doesn't added to map and not visible.

Investigation outcome:

WFS's getFeatureURL doesn't allow merging parameters correctly. Format parameter should specify search: undefined to allow formulation of the url and params merging correctly. Check if this change is required elsewhere with similar function wrt WFS

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

@mahmoudadel54 mahmoudadel54 self-assigned this Apr 12, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Apr 12, 2024
- fix the issue behind not adding the wfs layer
- write the unit tests for this cahnge
@mahmoudadel54 mahmoudadel54 linked a pull request Apr 12, 2024 that will close this issue
12 tasks
@tdipisa tdipisa added this to the 2024.01.01 milestone Apr 15, 2024
dsuren1 added a commit that referenced this issue Apr 15, 2024
* #10193: Issue with WFS added via Query params
- fix the issue behind not adding the wfs layer
- write the unit tests for this cahnge

* Update web/client/api/WFS.js

---------

Co-authored-by: Suren <[email protected]>
@ElenaGallo ElenaGallo self-assigned this Apr 16, 2024
@ElenaGallo ElenaGallo added BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch Accepted labels Apr 16, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue May 9, 2024
…tions-it#10195)

* geosolutions-it#10193: Issue with WFS added via Query params
- fix the issue behind not adding the wfs layer
- write the unit tests for this cahnge

* Update web/client/api/WFS.js

---------

Co-authored-by: Suren <[email protected]>
tdipisa pushed a commit that referenced this issue May 10, 2024
* #10193: Issue with WFS added via Query params
- fix the issue behind not adding the wfs layer
- write the unit tests for this cahnge

* Update web/client/api/WFS.js

---------

Co-authored-by: Suren <[email protected]>
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment