Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to disable identify popup in case of no results #10545

Closed
1 of 6 tasks
tdipisa opened this issue Sep 16, 2024 · 0 comments · Fixed by #10557 or #10619
Closed
1 of 6 tasks

Option to disable identify popup in case of no results #10545

tdipisa opened this issue Sep 16, 2024 · 0 comments · Fixed by #10557 or #10619
Assignees
@ElenaGallo @mahmoudadel54
Labels
BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C044-VLAANDEREN-2024-SUPPORT enhancement
Milestone
2024.02.01

Comments

@tdipisa
Copy link
Member

tdipisa commented Sep 16, 2024

Description

It is requested a new configuration option to prevent the Identify popup from displaying in case of no results instead of showing the following:

image

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information

  • we will need to add a new flag to the plugin for enabling this alternative behaviour
  • if this flag is true instead of returning this we will return null, see renderEmptyPages method
@tdipisa tdipisa added enhancement BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C044-VLAANDEREN-2024-SUPPORT labels Sep 16, 2024
@tdipisa tdipisa added this to the 2024.02.01 milestone Sep 16, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Sep 18, 2024
@mahmoudadel54
geosolutions-it#10545: Option to disable identify popup in case of no…
a2a2112 
… results

Description:
- handle adding an option called 'hidePopupIfNoResults' to hide the identify popup
- add unit tests
- add jsdoc
@mahmoudadel54 mahmoudadel54 mentioned this issue Sep 18, 2024
Merged
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request Sep 18, 2024 that will close this issue
#10545: Option to disable identify popup in case of no results #10557
Merged
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Oct 4, 2024
@mahmoudadel54
geosolutions-it#10545: Option to disable identify popup in case of no…
5861bee 
… results

Description:
- revert changes in popupSupport files for ol and leaflet + related tests files
- handle hide popup for map viewer with css for openlayers and leaflet approach
- add unit tests
- edit map-popup.less file to handle hide the popup
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Oct 4, 2024
@mahmoudadel54
geosolutions-it#10545: Option to disable identify popup in case of no…
104b377 
… results

Description:
- handle adding an option called 'hidePopupIfNoResults' to hide the identify popup for mapviewer [for desktop and mobile] using css approach
- add unit tests
- add jsdoc
- edit style in map-popup.less
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Oct 4, 2024
@mahmoudadel54
geosolutions-it#10545: revert unnecessary changes
8330ab6
tdipisa pushed a commit that referenced this issue Oct 14, 2024
@mahmoudadel54
#10545: Option to disable identify popup in case of no results (#10557)
c5ed4d0 
* #10545: Option to disable identify popup in case of no results
Description:
- handle adding an option called 'hidePopupIfNoResults' to hide the identify popup
- add unit tests
- add jsdoc

* #10545: Option to disable identify popup in case of no results
Description:
- revert changes in popupSupport files for ol and leaflet + related tests files
- handle hide popup for map viewer with css for openlayers and leaflet approach
- add unit tests
- edit map-popup.less file to handle hide the popup

* #10545: revert unnecessary changes
@ElenaGallo ElenaGallo self-assigned this Oct 14, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Oct 17, 2024
@mahmoudadel54
geosolutions-it#10545: remove marker in case no results + hover ident…
1411c38 
…ify mode active and hideEmptyPopupOption with true
@mahmoudadel54 mahmoudadel54 mentioned this issue Oct 17, 2024
Merged
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request Oct 17, 2024 that will close this issue
#10545: fix Option to disable identify popup in case of no results #10619
Merged
12 tasks
MV88 pushed a commit that referenced this issue Oct 17, 2024
@mahmoudadel54
#10545: remove marker in case no results + hover identify mode active…
0101c6b 
… and hideEmptyPopupOption with true (#10619)
jnewmoyer pushed a commit to ngsllc/MapStore2 that referenced this issue Oct 17, 2024
@rmelarab-ngs @github-actions
@dependabot @offtherailz @landryb @rowheat02 @allyoucanmap @mahmoudadel54 @MV88
Sync Fork Updates -10.17.24 (#11)
a9e0072 
* Update Changelog for version 2024.02.00 (geosolutions-it#10602)

Co-authored-by: github-actions <[email protected]>

* Bump commons-io:commons-io from 2.7 to 2.14.0 (geosolutions-it#10593)

* Removed react-confirm-button unused dependency (geosolutions-it#10495)

* Update release_steps.md (geosolutions-it#10568)

* Remove istambul loader (geosolutions-it#10491)

* Attempt to remove instambul loader

* removed also package dependency

* Apply suggestions from code review

clean

* Remove jsonpath (geosolutions-it#10494)

jsonpath is not needed. It is a dependency of geosolutions-it/patcher actually.
Having this dependency here is only confusing for dependency analyisis

* Fix geosolutions-it#10595 add missing 'FORMAT' parameter to WMTS GetFeatureInfo requests (geosolutions-it#10596)

* add missing 'FORMAT' parameter to WMTS GetFeatureInfo requests

this is required by the WMTS spec to be the same format as would
be used for a GetTile request, and this allows GFI requests to
succeed on https://data.geopf.fr/wmts.

* fix mapinfo wmts utils test

* Fix geosolutions-it#10505 Allow to specify use of proxy or cors at layer level (geosolutions-it#10526)

* fix: remove ui element for force proxy and Allow not secure layers

* fix: ajax logic changed, autoDetectCORS is set to true by default

* new central CORS util file created and used in ajax

* checking CORS before adding in common layer file

* null check on getProxyUrl

* updated individual layer considring to use proxy if needed

* avoid proxy cache to update if response is not okey

* enable user to add http url, show warning instead of error, warning text updated

* test cases updated

* fix: resolve conflicts with url check

* fixed the failed test

* review cesium layers

* include add method in model layer

* improve http check for openlayers wms layer

* fix tests

---------

Co-authored-by: allyoucanmap <[email protected]>

* Update openId.md (geosolutions-it#10610)

* Bump spring-security version to 5.7.12 (fixes geosolutions-it#10611) (geosolutions-it#10612)

somehow something in the build already drags this version, and we
end up with two conflicting versions of spring-security in the war
which results in at least failure to authenticate with basic auth.

* Visibility limits - The resolution option is not retained as Limits type geosolutions-it#10391 (geosolutions-it#10598)

* Add lib check release step (geosolutions-it#10614)

* geosolutions-it#4675 Remove unused code (geosolutions-it#10442)

* geosolutions-it#4675 Remove unused code

* remove additional code from review

* fix tests folder

* remove additional unused files

* geosolutions-it#10545: Option to disable identify popup in case of no results (geosolutions-it#10557)

* geosolutions-it#10545: Option to disable identify popup in case of no results
Description:
- handle adding an option called 'hidePopupIfNoResults' to hide the identify popup
- add unit tests
- add jsdoc

* geosolutions-it#10545: Option to disable identify popup in case of no results
Description:
- revert changes in popupSupport files for ol and leaflet + related tests files
- handle hide popup for map viewer with css for openlayers and leaflet approach
- add unit tests
- edit map-popup.less file to handle hide the popup

* geosolutions-it#10545: revert unnecessary changes

* Fix geosolutions-it#10615 removed eval from marker utils (geosolutions-it#10616)

* geosolutions-it#10545: remove marker in case no results + hover identify mode active and hideEmptyPopupOption with true (geosolutions-it#10619)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Landry Breuil <[email protected]>
Co-authored-by: RowHeat <[email protected]>
Co-authored-by: allyoucanmap <[email protected]>
Co-authored-by: mahmoud adel <[email protected]>
Co-authored-by: Matteo V. <[email protected]>
offtherailz pushed a commit that referenced this issue Oct 18, 2024
@mahmoudadel54 @offtherailz
#10545: Option to disable identify popup in case of no results (#10557)
e26b72a 
* #10545: Option to disable identify popup in case of no results
Description:
- handle adding an option called 'hidePopupIfNoResults' to hide the identify popup
- add unit tests
- add jsdoc

* #10545: Option to disable identify popup in case of no results
Description:
- revert changes in popupSupport files for ol and leaflet + related tests files
- handle hide popup for map viewer with css for openlayers and leaflet approach
- add unit tests
- edit map-popup.less file to handle hide the popup

* #10545: revert unnecessary changes
offtherailz pushed a commit that referenced this issue Oct 18, 2024
@mahmoudadel54 @offtherailz
#10545: remove marker in case no results + hover identify mode active…
2d8c4cb 
… and hideEmptyPopupOption with true (#10619)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaGallo ElenaGallo

@mahmoudadel54 mahmoudadel54

Labels
BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C044-VLAANDEREN-2024-SUPPORT enhancement
Projects
None yet
Milestone
2024.02.01
3 participants
@tdipisa @ElenaGallo @mahmoudadel54