Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve layer settings performances #9120

Closed
Tracked by #9099
offtherailz opened this issue Apr 20, 2023 · 0 comments · Fixed by #9121
Closed
Tracked by #9099

Improve layer settings performances #9120

offtherailz opened this issue Apr 20, 2023 · 0 comments · Fixed by #9121

Comments

@offtherailz
Copy link
Member

offtherailz commented Apr 20, 2023

While implementing #9099, I noticed a performance problem in layer settings. (TOCItemSettings)

This is due basically to the current implementation and some forced rerenders of all the plugin forced to support the thematic layer plugin. These force re-render are due to some changes applied to the core objects only to support Thematic Layer

We need to refactor and cleanup the implementation of the plugin at least to allow to type data without visible performance issues.
Now a change causes 150ms-200ms re-rendering (this is masked basically by making the input boxes update the fields on blur, but we can not workorund this problem anymore).
This have to be fixed if we want to type and change things live, and for handling easely the future changes to this tool, too.

Here a sample of the warning.

Peek.20-04-2023.15-21.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants