Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map views mask is not working #9159

Closed
1 task done
allyoucanmap opened this issue May 12, 2023 · 0 comments · Fixed by #9160 or #9167
Closed
1 task done

Map views mask is not working #9159

allyoucanmap opened this issue May 12, 2023 · 0 comments · Fixed by #9160 or #9167
Assignees
@allyoucanmap @ElenaGallo
Labels
Accepted bug Regression
Milestone
2023.01.02

Comments

@allyoucanmap
Copy link
Contributor

allyoucanmap commented May 12, 2023 •
edited
Loading

Description

This PR #9074 (issue #9067) introduced some enhancement to correctly visualize the clamp to ground. The same PR changes the default clamp to ground to false to improve also the initial performance of the style (clamp to ground false is faster to render).
The Map Views mask layer have not the msClampToGround and msClassificationType properties in the style and this is causing the regression

How to reproduce

  • login
  • open this map

Expected Result

The 3D Tile is masked and showing only an area (Football pitch)

image

Current Result

The 3D Tile is not visible

image

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information
@allyoucanmap allyoucanmap added this to the 2023.01.02 milestone May 12, 2023
@allyoucanmap allyoucanmap self-assigned this May 12, 2023
@allyoucanmap allyoucanmap removed this from the 2023.01.02 milestone May 12, 2023
allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this issue May 12, 2023
@allyoucanmap
Fix geosolutions-it#9159 Map views mask is not working
15bce89
@allyoucanmap allyoucanmap mentioned this issue May 12, 2023
Merged
5 tasks
@allyoucanmap allyoucanmap linked a pull request May 12, 2023 that will close this issue
Fix #9159 Map views mask is not working #9160
Merged
5 tasks
@tdipisa tdipisa added this to the 2023.01.02 milestone May 12, 2023
@ElenaGallo ElenaGallo self-assigned this May 12, 2023
allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this issue May 12, 2023
@allyoucanmap
Fix geosolutions-it#9159 Map views mask is not working (geosolutions-…
08485fb 
…it#9160)
@allyoucanmap allyoucanmap mentioned this issue May 12, 2023
Merged
5 tasks
@allyoucanmap allyoucanmap linked a pull request May 12, 2023 that will close this issue
[Backport 2023.01.xx] Fix #9159 Map views mask is not working (#9160) #9167
Merged
5 tasks
tdipisa pushed a commit that referenced this issue May 15, 2023
@allyoucanmap
Fix #9159 Map views mask is not working (#9160) (#9167)
da7a876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allyoucanmap allyoucanmap

@ElenaGallo ElenaGallo

Labels
Accepted bug Regression
Projects
None yet
Milestone
2023.01.02
3 participants
@tdipisa @allyoucanmap @ElenaGallo