Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline map sync does not update for time ranges visualization #9208

Closed
1 task done
allyoucanmap opened this issue Jun 1, 2023 · 2 comments · Fixed by #9209 or #9211
Closed
1 task done

Timeline map sync does not update for time ranges visualization #9208

allyoucanmap opened this issue Jun 1, 2023 · 2 comments · Fixed by #9209 or #9211

Comments

@allyoucanmap
Copy link
Contributor

allyoucanmap commented Jun 1, 2023

Description

The timeline chart does not update based on viewport even if the map sync button is selected.

time-map-sync.mp4

How to reproduce

  • open this map (login as admin if needed)
  • expand the timeline
  • zoom on a feature to exclude the other
  • click on map sync

Expected Result

The timeline should update the visualization of time intervals based on the viewport of the map

Current Result

The timeline does not update the visualization of time intervals based on the viewport of the map

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

The sync issue it seems related to inconsistent state of the time domain property. The timeline updates the new range data inside the updateRangeDataOnRangeChange epic dispatching rangeDataLoaded action and then read the new histograms and rang line items using the itemsSelector. The itemsSelector is using different parts of the state to create the correct items used by the timeline for the visualization:

  • layer reducer static domain properties
  • dimension reducer domain properties
  • timeline reducer rangeData properties

After some check it seems that even if the rangeData is correctly updated the dimension reducers is still containing information related to domain that are taking precedence over the new rangeData.
We will need to review the update workflow of range data to properly fix this issue.

@offtherailz
Copy link
Member

I noticed that with this map works.
https://dev-mapstore.geosolutionsgroup.com/mapstore/#/viewer/42064
What's the difference ?

@ale-cristofori
Copy link
Contributor

I noticed that with this map works. https://dev-mapstore.geosolutionsgroup.com/mapstore/#/viewer/42064 What's the difference ?

@offtherailz, I suspect it is because the time dimension on the layers included in the map you link is unique rather than a range (start/end date).

tdipisa pushed a commit that referenced this issue Jun 5, 2023
…tion (#9209)

* Fix #9208 Timeline map sync does not update for time ranges visualization

* move the default expand limit value to selector
@ElenaGallo ElenaGallo self-assigned this Jun 6, 2023
allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this issue Jun 7, 2023
…anges visualization (geosolutions-it#9209)

* Fix geosolutions-it#9208 Timeline map sync does not update for time ranges visualization

* move the default expand limit value to selector
tdipisa pushed a commit that referenced this issue Jun 7, 2023
…tion (#9209) (#9211)

* Fix #9208 Timeline map sync does not update for time ranges visualization

* move the default expand limit value to selector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment