Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MIME type support for info_format=application/geo+json for getFeatureInfo #9564

Closed
1 task
ale-cristofori opened this issue Oct 5, 2023 · 3 comments · Fixed by #9917
Closed
1 task

Comments

@ale-cristofori
Copy link
Contributor

ale-cristofori commented Oct 5, 2023

Description

Some upstream getFeatureInfo providing WMS services will not accept info_format=application/json as valid parameter for requesting getFeatureInfo result in the properties format, returning the results in JSON format.

Acceptance criteria

to get back only the properties of the returned features and process them as result of getFeatureInfo

Other useful information

in the getCapabilities of the above WMS service (ESRI) the MIME type is included in the supported for getFeatureInfo
https://geo.api.test-vlaanderen.be/DHMV/wms?service=WMS&version=1.1.1&request=GetCapabilities

@tdipisa
Copy link
Member

tdipisa commented Oct 18, 2023

@ale-cristofori

  1. I understand you are asking here to support application/geo+json as possible GFI format in MS (currently we are not supporting)
  2. It is not possible to well connect MS to that WMS. 404 is always returned when we try to add layers to the map. Connecting to this is necessary to proceed with the investigation
  3. This is an ArcGIS Server (I saw it from 404 error message returned) therefore Service Type as No Vendor should be used in Advanced Options @mahmoudadel54.

@ale-cristofori
Copy link
Contributor Author

ale-cristofori commented Oct 30, 2023

@tdipisa

I understand you are asking here to support application/geo+json as possible GFI format in MS (currently we are not supporting)

Yes this is the requirement in a few words.

  1. It is not possible to well connect MS to that WMS. 404 is always returned when we try to add layers to the map. Connecting to this is necessary to proceed with the investigation

I noticed that too. I opened that in a local MapStore and I can access the getCapabilities and visualize the layers, I did not test each one of them but the layers Digitaal Hoogtemodel Vlaanderen I, digitaal terreinmodel 5 m and Vectorlaag die voor ieder deel van het bijhorende product de opnamedatum weergeeft. seem to work. Since locally I have some clients based MS2 versions this needs to be tested with master because it contains this fix #9466 (not yet released). Also, as specified by @tdipisa Service Type as No Vendor should be used in Advanced Options. So the solution would be to develop locally. I am not sure why adding the service on dev does not work.
See below how to do it

image

@tdipisa tdipisa assigned MV88 and unassigned mahmoudadel54 Nov 16, 2023
@geosolutions-it geosolutions-it deleted a comment from MV88 Nov 17, 2023
@tdipisa tdipisa added the new label Jan 15, 2024
@tdipisa tdipisa assigned tdipisa and unassigned MV88 Jan 15, 2024
@tdipisa tdipisa added this to the 2024.01.00 milestone Jan 15, 2024
@tdipisa tdipisa assigned Igi-ID and unassigned tdipisa Jan 15, 2024
@tdipisa tdipisa removed the new label Jan 15, 2024
@offtherailz
Copy link
Member

offtherailz commented Jan 16, 2024

Here we have 2 problems:
1 - Proxy seems to raise an error on the getcapabilities request - This have to be investigated separetely.
2 - On front-end side, MapStore recognize only application/json while the server provided (https://geo.api.test-vlaanderen.be/DHMV/wms) returns application/geo+json.

So the purpose of this issue is to support this alternative info_format in MapStore, treating it as an alias of application/json.

This means we need to:

  • On catalog, to list the application/geo+json as an alternative format.
  • In any case, pass to the layers the name of the format parameter that have to be used by to receive json format- This format have to be saved in the layer object of the map, so a second time the map is able to do the request with the correct parameter (featureInfo object of hte layer should be already saved and so inside that object
  • MapStore (feature info etc) should use the format string in metadata when asking for feature info data in all the cases.
    • Popup feature info
    • Normal feature info
    • possibily also the embedded maps in geostory and dashboard have to be tested
  • If no format has been provided, use the default application/json (for backward compability).

@Igi-ID Igi-ID linked a pull request Jan 26, 2024 that will close this issue
5 tasks
@ElenaGallo ElenaGallo assigned tdipisa and ElenaGallo and unassigned tdipisa Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants