Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow time range filtering for Attribute Table quick filter #9706

Closed
1 of 13 tasks
mahmoudadel54 opened this issue Nov 16, 2023 · 2 comments · Fixed by #9743
Closed
1 of 13 tasks

Allow time range filtering for Attribute Table quick filter #9706

mahmoudadel54 opened this issue Nov 16, 2023 · 2 comments · Fixed by #9743
Assignees
@dsuren1 @ElenaGallo
Labels
Accepted C040-COMUNE_GE-2023-CUSTOM-SUPPORT enhancement
Milestone
2024.01.00

Comments

@mahmoudadel54
Copy link
Contributor

mahmoudadel54 commented Nov 16, 2023 •
edited by MV88
Loading

Description

Enhance the quick filter for time attributes to be able to filter by time range.

  • create a new datetime icon
  • remove the double icon present for date time
  • add an operator for date, time and datetime with same list from filterfield
  • if operator is >< datepicker will open with mode "range"
  • otherwise it will open in single mode
  • as soon there is a valid range or single date/time it gets applied in the attribute table
  • an x should close the popover

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information

Suggested mockup

range_picker
@mahmoudadel54 mahmoudadel54 self-assigned this Nov 16, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 22, 2023
@mahmoudadel54
geosolutions-it#9706: handle the advanced filter in attribute table w…
7f3c2e7 
…ith different operators
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 23, 2023
@mahmoudadel54
geosolutions-it#9706: Allow time range filtering for Attribute Table …
fc0f4c8 
…quick filter and allow additional filter operators for other attributes

Description:
- adding filter operators dropdown list in attribute table that includes range operator for time/date attributes
- creating a custom picker for range
- write unit tests
- Edit in style
@mahmoudadel54 mahmoudadel54 mentioned this issue Nov 23, 2023
Merged
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request Nov 23, 2023 that will close this issue
#9706: Allow time range filtering for Attribute Table quick filter #9743
Merged
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 23, 2023
@mahmoudadel54
geosolutions-it#9706: fix test failure by remove unused variable
7edb767
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 23, 2023
@mahmoudadel54
geosolutions-it#9706: fix test failure by remove unused action in fea…
2bec670 
…turegrid file
@tdipisa tdipisa added this to the 2024.01.00 milestone Nov 27, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Dec 1, 2023
@mahmoudadel54
geosolutions-it#9706: resolve review comments
d8d1ae8 
Desciption:
- remove expression from filter inputs and make validation for the inputs
- Add cursor style to 'Start' & 'End' tabs
- Add validation for  ranges
- Replace 2 icons with one icon for date-time filter
- Fix style issues
- Fixed 'Start', 'End' tabs in scroll
- improve style of operator
- reset date/time if user change operator from range operator to another
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Dec 1, 2023
@mahmoudadel54
geosolutions-it#9706: fix test case in AttributeFilter file
70e7e69
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Dec 18, 2023
@mahmoudadel54
geosolutions-it#9706: Allow time range filtering for Attribute Table …
c4f5640 
…quick filter

* Description:
- Add date-time icon and use it
- replcae inline if
- using omit instead of reduce
- fix some style issues in date/time pickers in range component
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Dec 18, 2023
@mahmoudadel54
geosolutions-it#9706: Allow time range filtering for Attribute Table …
322d3d4 
…quick filter

* Description:
- Fix FE test failure
@MV88
Copy link
Contributor

MV88 commented Dec 21, 2023

blocked for this reason
#9743 (comment)

@tdipisa
Copy link
Member

tdipisa commented Jan 8, 2024

@mahmoudadel54 please proceed with the pending fix, thank you.

mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jan 14, 2024
@mahmoudadel54
geosolutions-it#9706: resolve reviewer comments [improve UI of pickers]
e105916 
Description:
- Improve UI of pickers by using popover component in dateTime/Date/Hours pickers
- Enable update popover position in case of scroll the container conponent
-  write unit tests due to changes
- Rename range date-time picker by 'RangedDateTimePicker'
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jan 16, 2024
@mahmoudadel54
geosolutions-it#9706: resolve reviewer comments
2960978 
Description:
- Handle highlight selected hours component
- Fix not alignment in dateTime picker
- Fix not alignment selected date in calendar for date/ dateTime pickers
- Minimize calendar row height to improve showing date picker UI
- Create a util function  'getLocalTimePart' to get time part for local time
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jan 16, 2024
@mahmoudadel54
geosolutions-it#9706: resolve FE test failure
ad64e56
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jan 18, 2024
@mahmoudadel54
geosolutions-it#9706: resolve reviewer comments
ad2ff6f 
Description:
- Add placeholder for time picker
- Add translations for the added time placeholder
- Fix crash app bug due to entering invalid date in input texts of date/time Pickers
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jan 18, 2024
@mahmoudadel54
geosolutions-it#9706: hide input tooltip when user open pickers
bd0c36f
@tdipisa tdipisa assigned dsuren1 and unassigned mahmoudadel54 Jan 19, 2024
MV88 pushed a commit that referenced this issue Jan 22, 2024
@mahmoudadel54 @dsuren1
#9706: Allow time range filtering for Attribute Table quick filter (#…
93ea6ea 
…9743)

* #9706: handle the advanced filter in attribute table with different operators

* #9706: Allow time range filtering for Attribute Table quick filter and allow additional filter operators for other attributes
Description:
- adding filter operators dropdown list in attribute table that includes range operator for time/date attributes
- creating a custom picker for range
- write unit tests
- Edit in style

* #9706: fix test failure by remove unused variable

* #9706: fix test failure by remove unused action in featuregrid file

* #9706: resolve review comments
Desciption:
- remove expression from filter inputs and make validation for the inputs
- Add cursor style to 'Start' & 'End' tabs
- Add validation for  ranges
- Replace 2 icons with one icon for date-time filter
- Fix style issues
- Fixed 'Start', 'End' tabs in scroll
- improve style of operator
- reset date/time if user change operator from range operator to another

* #9706: fix test case in AttributeFilter file

* #9706: Allow time range filtering for Attribute Table quick filter
* Description:
- Add date-time icon and use it
- replcae inline if
- using omit instead of reduce
- fix some style issues in date/time pickers in range component

* #9706: Allow time range filtering for Attribute Table quick filter
* Description:
- Fix FE test failure

* #9706: resolve reviewer comments [improve UI of pickers]
Description:
- Improve UI of pickers by using popover component in dateTime/Date/Hours pickers
- Enable update popover position in case of scroll the container conponent
-  write unit tests due to changes
- Rename range date-time picker by 'RangedDateTimePicker'

* #9706: resolve reviewer comments
Description:
- Handle highlight selected hours component
- Fix not alignment in dateTime picker
- Fix not alignment selected date in calendar for date/ dateTime pickers
- Minimize calendar row height to improve showing date picker UI
- Create a util function  'getLocalTimePart' to get time part for local time

* #9706: resolve FE test failure

* #9706: resolve reviewer comments
Description:
- Add placeholder for time picker
- Add translations for the added time placeholder
- Fix crash app bug due to entering invalid date in input texts of date/time Pickers

* #9706: hide input tooltip when user open pickers

* Time filter refactor

* unit test

---------

Co-authored-by: Suren <[email protected]>
@ElenaGallo ElenaGallo self-assigned this Jan 22, 2024
@ElenaGallo ElenaGallo mentioned this issue Jan 23, 2024
Closed
2 tasks
@tdipisa tdipisa mentioned this issue Jul 24, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsuren1 dsuren1

@ElenaGallo ElenaGallo

Labels
Accepted C040-COMUNE_GE-2023-CUSTOM-SUPPORT enhancement
Projects
None yet
Milestone
2024.01.00
Development

Successfully merging a pull request may close this issue.

#9706: Allow time range filtering for Attribute Table quick filter mahmoudadel54/MapStore2
5 participants
@tdipisa @MV88 @dsuren1 @ElenaGallo @mahmoudadel54