Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancing GeoFence attribute rule editor #9752

Closed
1 of 6 tasks
mahmoudadel54 opened this issue Nov 27, 2023 · 0 comments · Fixed by #9753 or #9755
Closed
1 of 6 tasks

Enhancing GeoFence attribute rule editor #9752

mahmoudadel54 opened this issue Nov 27, 2023 · 0 comments · Fixed by #9753 or #9755
Assignees
@ElenaGallo @mahmoudadel54
Labels
Accepted C040-COMUNE_GE-2023-CUSTOM-SUPPORT enhancement
Milestone
2024.01.00

Comments

@mahmoudadel54
Copy link
Contributor

mahmoudadel54 commented Nov 27, 2023 •
edited by tdipisa
Loading

Description

That's a UI/UX improvement for the GeoFence rule editor.

Image

changes performed by the user when editing access permissions on feature attributes using the DD must be highlighted somehow in the UI to make it more clear to the user what has been changed. After saving the changes the highlight disappear.

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information
@mahmoudadel54 mahmoudadel54 self-assigned this Nov 27, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 27, 2023
@mahmoudadel54
geosolutions-it#9752: enhance geofence attribute rule editor:
5fac0ca 
Description:
- Highlight only the edited attributes
- Write unit test
- Fix style issue in grid_rules_manager
@mahmoudadel54 mahmoudadel54 mentioned this issue Nov 27, 2023
Merged
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request Nov 27, 2023 that will close this issue
#9752: enhance geofence attribute rule editor #9753
Merged
12 tasks
MV88 pushed a commit that referenced this issue Nov 27, 2023
@mahmoudadel54
#9752: enhance geofence attribute rule editor: (#9753)
0a1d17b 
Description:
- Highlight only the edited attributes
- Write unit test
- Fix style issue in grid_rules_manager
@MV88 MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 27, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Nov 27, 2023
@mahmoudadel54
geosolutions-it#9752: enhance geofence attribute rule editor: (geosol…
3f079e5 
…utions-it#9753)

Description:
- Highlight only the edited attributes
- Write unit test
- Fix style issue in grid_rules_manager
@mahmoudadel54 mahmoudadel54 mentioned this issue Nov 27, 2023
Merged
@mahmoudadel54 mahmoudadel54 linked a pull request Nov 27, 2023 that will close this issue
[Backport C040-2023.02.xx] #9752: enhance geofence attribute rule editor: (#9753) #9755
Merged
MV88 pushed a commit that referenced this issue Nov 27, 2023
@mahmoudadel54
#9752: enhance geofence attribute rule editor: (#9753) (#9755)
4f2e7e9 
Description:
- Highlight only the edited attributes
- Write unit test
- Fix style issue in grid_rules_manager
@MV88 MV88 removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 27, 2023
@ElenaGallo ElenaGallo self-assigned this Nov 27, 2023
@ElenaGallo ElenaGallo added this to the 2024.01.00 milestone Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaGallo ElenaGallo

@mahmoudadel54 mahmoudadel54

Labels
Accepted C040-COMUNE_GE-2023-CUSTOM-SUPPORT enhancement
Projects
None yet
Milestone
2024.01.00
3 participants
@MV88 @ElenaGallo @mahmoudadel54