Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visibility limits not working in 3D for detached layers #9775

Closed
1 task done
allyoucanmap opened this issue Nov 30, 2023 · 0 comments · Fixed by #9777 or #9812
Closed
1 task done

Visibility limits not working in 3D for detached layers #9775

allyoucanmap opened this issue Nov 30, 2023 · 0 comments · Fixed by #9777 or #9812
Assignees
@allyoucanmap @ElenaGallo
Labels
3D All issues related to the 3D rendering in CesiumJs Accepted bug C027-COMUNE_FI-2023-SUPPORT
Milestone
2023.02.02

Comments

@allyoucanmap
Copy link
Contributor

Description

The visibility limits and in general the visibility system does not work as expected in 3D map. The following types of layers should be checked:

  • 3D Tiles
  • WFS
  • Vector
  • Terrain

How to reproduce

  • create a new map
  • add a 3d tiles layer
  • configure the visibility limits of the layer and make sure the layer will not be visible in the current scale
  • save the map with the layer not visible because of the visibility limit state
  • reload the page

Expected Result

  • the 3d tiles layer is not visible because of the visibility limits rules applied

Current Result

  • the 3d tiles layer is visible even if the visibility limits rules are applied

  • Not browser related

Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information
@allyoucanmap allyoucanmap added bug 3D All issues related to the 3D rendering in CesiumJs C027-COMUNE_FI-2023-SUPPORT labels Nov 30, 2023
@allyoucanmap allyoucanmap self-assigned this Nov 30, 2023
@allyoucanmap allyoucanmap modified the milestones: 2023.02.01, 2023.02.02 Nov 30, 2023
allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this issue Nov 30, 2023
@allyoucanmap
Fix geosolutions-it#9775 Visibility limits not working in 3D for deta…
a99ccd2 
…ched layers
@allyoucanmap allyoucanmap mentioned this issue Nov 30, 2023
Merged
5 tasks
@tdipisa tdipisa linked a pull request Dec 1, 2023 that will close this issue
Fix #9775 Visibility limits not working in 3D for detached layers #9777
Merged
5 tasks
@MV88 MV88 closed this as completed in #9777 Dec 6, 2023
MV88 pushed a commit that referenced this issue Dec 6, 2023
@allyoucanmap
Fix #9775 Visibility limits not working in 3D for detached layers (#9777
eca6b14 
)

* Fix #9775 Visibility limits not working in 3D for detached layers

* requested changes

* udpate zoom from height comment
@ElenaGallo ElenaGallo added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Dec 6, 2023
@ElenaGallo ElenaGallo self-assigned this Dec 6, 2023
allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this issue Dec 13, 2023
@allyoucanmap
Fix geosolutions-it#9775 Visibility limits not working in 3D for deta…
577959a 
…ched layers (geosolutions-it#9777)

* Fix geosolutions-it#9775 Visibility limits not working in 3D for detached layers

* requested changes

* udpate zoom from height comment
@allyoucanmap allyoucanmap mentioned this issue Dec 13, 2023
Merged
5 tasks
@allyoucanmap allyoucanmap linked a pull request Dec 13, 2023 that will close this issue
[Backport 2023.02.xx] Fix #9775 Visibility limits not working in 3D for detached layers (#9777) #9812
Merged
5 tasks
tdipisa pushed a commit that referenced this issue Dec 13, 2023
@allyoucanmap
[Backport 2023.02.xx] Fix #9775 Visibility limits not working in 3D f…
bf050d7 
…or detached layers (#9777) (#9812)

* Fix #9775 Visibility limits not working in 3D for detached layers (#9777)

* Fix #9775 Visibility limits not working in 3D for detached layers

* requested changes

* udpate zoom from height comment

* fix failing tests
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Dec 13, 2023
@tdipisa tdipisa mentioned this issue Dec 13, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allyoucanmap allyoucanmap

@ElenaGallo ElenaGallo

Labels
3D All issues related to the 3D rendering in CesiumJs Accepted bug C027-COMUNE_FI-2023-SUPPORT
Projects
None yet
Milestone
2023.02.02
3 participants
@tdipisa @allyoucanmap @ElenaGallo