Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Options to enable mapInfo highlight by default #9825

Closed
1 of 6 tasks
tdipisa opened this issue Dec 18, 2023 · 0 comments · Fixed by #9829 or #9871
Closed
1 of 6 tasks

Options to enable mapInfo highlight by default #9825

tdipisa opened this issue Dec 18, 2023 · 0 comments · Fixed by #9829 or #9871
Assignees
@ElenaGallo @mahmoudadel54
Labels
Accepted C206-DEUTSCHE_BAHN-2023-SUPPORT enhancement
Milestone
2023.02.02

Comments

@tdipisa
Copy link
Member

tdipisa commented Dec 18, 2023

Description

currently is not possible to configure the tool to have the feature highlight option active by default.

Image

It is requested small improvement to provide a new configuration option for it. The highlight will stay anyway set to false as default in official MS.

What kind of improvement you want to add? (check one with "x", remove the others)

  • Minor changes to existing features
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Other useful information
@tdipisa tdipisa added this to the 2023.02.02 milestone Dec 18, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Dec 19, 2023
@mahmoudadel54
geosolutions-it#9825: Add option to enable mapInfo highlight by default
9b9c1ed 
* Description:
- Adding an option called "identifyHighlight" to enable/disable mapInfo highlight by default in localConfig file
- implement intiate highlight value based on the added option and the default is false
- write unit tests based on change
@mahmoudadel54 mahmoudadel54 mentioned this issue Dec 19, 2023
Merged
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request Dec 19, 2023 that will close this issue
#9825: Add an config option to enable mapInfo highlight by default #9829
Merged
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Dec 19, 2023
@mahmoudadel54
geosolutions-it#9825: Add option to enable mapInfo highlight by default
480fabf 
* Description:
- fix FE test failure by editing a unit test in identifyContainer that test calling initiateOrResetHighlight on close identify
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Dec 21, 2023
@mahmoudadel54
geosolutions-it#9825: Add option to enable mapInfo highlight by default
2fe3010 
* Description:
- resolve review comments by using INIT_PLUGIN action instead of the new created one
- Remove the new created action ' INIT_IDENTIFY_HIGHLIGHT' and its dependent code
- Remove the added config from localConfig file
@MV88 MV88 closed this as completed in #9829 Jan 9, 2024
MV88 pushed a commit that referenced this issue Jan 9, 2024
@mahmoudadel54
#9825: Add an config option to enable mapInfo highlight by default (#…
c72e60f 
…9829)

* #9825: Add option to enable mapInfo highlight by default
* Description:
- Adding an option called "identifyHighlight" to enable/disable mapInfo highlight by default in localConfig file
- implement intiate highlight value based on the added option and the default is false
- write unit tests based on change

* #9825: Add option to enable mapInfo highlight by default
* Description:
- fix FE test failure by editing a unit test in identifyContainer that test calling initiateOrResetHighlight on close identify

* #9825: Add option to enable mapInfo highlight by default
* Description:
- resolve review comments by using INIT_PLUGIN action instead of the new created one
- Remove the new created action ' INIT_IDENTIFY_HIGHLIGHT' and its dependent code
- Remove the added config from localConfig file
@tdipisa tdipisa added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jan 9, 2024
@ElenaGallo ElenaGallo self-assigned this Jan 11, 2024
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jan 11, 2024
@mahmoudadel54
geosolutions-it#9825: Add an config option to enable mapInfo highligh…
d1bca29 
…t by default (geosolutions-it#9829)

* geosolutions-it#9825: Add option to enable mapInfo highlight by default
* Description:
- Adding an option called "identifyHighlight" to enable/disable mapInfo highlight by default in localConfig file
- implement intiate highlight value based on the added option and the default is false
- write unit tests based on change

* geosolutions-it#9825: Add option to enable mapInfo highlight by default
* Description:
- fix FE test failure by editing a unit test in identifyContainer that test calling initiateOrResetHighlight on close identify

* geosolutions-it#9825: Add option to enable mapInfo highlight by default
* Description:
- resolve review comments by using INIT_PLUGIN action instead of the new created one
- Remove the new created action ' INIT_IDENTIFY_HIGHLIGHT' and its dependent code
- Remove the added config from localConfig file
@mahmoudadel54 mahmoudadel54 mentioned this issue Jan 11, 2024
Merged
@mahmoudadel54 mahmoudadel54 linked a pull request Jan 11, 2024 that will close this issue
[Backport 2023.02.xx] #9825: Add an config option to enable mapInfo highlight by default (#9829) #9871
Merged
MV88 pushed a commit that referenced this issue Jan 11, 2024
@mahmoudadel54
#9825: Add an config option to enable mapInfo highlight by default (#…
036bc05 
…9829) (#9871)

* #9825: Add option to enable mapInfo highlight by default
* Description:
- Adding an option called "identifyHighlight" to enable/disable mapInfo highlight by default in localConfig file
- implement intiate highlight value based on the added option and the default is false
- write unit tests based on change

* #9825: Add option to enable mapInfo highlight by default
* Description:
- fix FE test failure by editing a unit test in identifyContainer that test calling initiateOrResetHighlight on close identify

* #9825: Add option to enable mapInfo highlight by default
* Description:
- resolve review comments by using INIT_PLUGIN action instead of the new created one
- Remove the new created action ' INIT_IDENTIFY_HIGHLIGHT' and its dependent code
- Remove the added config from localConfig file
@ElenaGallo ElenaGallo added Accepted and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElenaGallo ElenaGallo

@mahmoudadel54 mahmoudadel54

Labels
Accepted C206-DEUTSCHE_BAHN-2023-SUPPORT enhancement
Projects
None yet
Milestone
2023.02.02
3 participants
@tdipisa @ElenaGallo @mahmoudadel54