Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Print] Ability to print image legend with an appropriate scale #9839

Closed
dsuren1 opened this issue Dec 20, 2023 · 1 comment · Fixed by #9847 or #9864
Closed

[Print] Ability to print image legend with an appropriate scale #9839

dsuren1 opened this issue Dec 20, 2023 · 1 comment · Fixed by #9847 or #9864

Comments

@dsuren1
Copy link
Contributor

dsuren1 commented Dec 20, 2023

Description

Provide the ability to print legend image with the configured scale of the layer in the layer options (Display -> Legends).

Currently the MS uses the iconSize of the legend options in print tool to set width and height of the legend
Screenshot 2023-12-14 at 12 16 26 PM

Example: with internal layer

iconSize: 20 iconSize: 40
Screenshot 2023-12-14 at 12 15 10 PM Screenshot 2023-12-14 at 12 14 05 PM

The print tool's Legend Options will be modified to have two fields called Width and Height replacing the Icon Size field along with a new checkbox field called Override icon size. These new fields will hold the current default size of 24px.
This override option will allow user to override legend's configured scale (width and height) set for the layer in the layer options and when more than one layer is present, this option will be applied for the all the applicable layers.

By default, this option will be unchecked, meaning the legend's width and height configured in layer will be used per layer

Reason: Print tool has a common option for all the layers selected for printing and cannot be made available per layer, hence a common option will be used for all layer when user prefer to override the icon size

image

Other useful information

Ref: georchestra/mapstore2-georchestra#682

@dsuren1
Copy link
Contributor Author

dsuren1 commented Dec 21, 2023

Updated:

The legend options will have checkbox Override icon size, this will override legend's width and height set for the layer in the layer options and will be applied for the all the applicable layers. By default, this option will be unchecked, meaning the legend's width and height configured in layer will be used.

Reason: Print tool has a common option for all the layers selected for printing and cannot be made available per layer in the print tool, hence a common option will be used for all layer when user prefer to override the icon size

image

dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Dec 22, 2023
@dsuren1 dsuren1 linked a pull request Dec 22, 2023 that will close this issue
5 tasks
@ElenaGallo ElenaGallo added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jan 9, 2024
@ElenaGallo ElenaGallo self-assigned this Jan 10, 2024
dsuren1 added a commit to dsuren1/MapStore2 that referenced this issue Jan 10, 2024
tdipisa pushed a commit that referenced this issue Jan 10, 2024
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment