Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline - Filter by Viewport won't filter correctly #9843

Closed
1 task done
ale-cristofori opened this issue Dec 20, 2023 · 8 comments
Closed
1 task done

Timeline - Filter by Viewport won't filter correctly #9843

ale-cristofori opened this issue Dec 20, 2023 · 8 comments

Comments

@ale-cristofori
Copy link
Contributor

ale-cristofori commented Dec 20, 2023

Description

Some work has been done to fix some filtering issues on the Timeline component when the 'filter by current viewport' button is enabled. For reference see #9268

Now, after further tests we noticed some outstanding filtering issues that still show data on the timeline while no data is displayed (for that current time or time range) in the map viewport.

How to reproduce

  • Open this map https://dev-mapstore.geosolutionsgroup.com/mapstore/#/viewer/46334
  • Zoom to the BBOX layer using the zoom to layer functionality on the layer item on the TOC
  • In the timeline component, click on the 'show only times available on the viewport' button.
  • Notice how despite the map viewport being empty we can still see a line on the TimeLine component for an interval of a feature that is not visible on the map

In doubt replicate the steps shown in the video below

291616106-954f8639-f1cb-4d0e-a4bb-09a14fa1c5ac.mp4

Expected Result

The map viewport does not display any features in the viewport for the donut 2011 layer and the TimeLine component should have no lines, reflecting what is on the map

Current Result

Notice how despite the map viewport not containing any features for the donut 2011 layer we can still see a line on the TimeLine component for an interval of a feature that is not visible on the map.

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

@offtherailz
Copy link
Member

@ale-cristofori this issue is not clear for me. So I can not assign to @Igi-ID for the moment. Could you put a clear list of steps or clarify more ?
Thank you. I assign it to you and put it on blocked in the meanwhile

@offtherailz offtherailz assigned ale-cristofori and unassigned Igi-ID Jan 16, 2024
@tdipisa
Copy link
Member

tdipisa commented Jan 16, 2024

@ale-cristofori the issue need to be better defined with proper steps to reproduce the problem and using the usual issue template.

@ale-cristofori
Copy link
Contributor Author

@offtherailz @tdipisa I changed the content of the issue

@offtherailz
Copy link
Member

@ale-cristofori the feature represented on the timeline is not visible on the map because the time selected to not include the line. If you move the current time (or current-time interval) to overlap the line in the timeline, it is visible also on the map.

@ale-cristofori
Copy link
Contributor Author

ale-cristofori commented Jan 16, 2024

@offtherailz, I would need to re-verify this.

@ale-cristofori
Copy link
Contributor Author

ale-cristofori commented Jan 17, 2024

@offtherailz, I'm going review the full picture of the issue. At the moment this is blocked until I've clarified what the issue is.

@ale-cristofori
Copy link
Contributor Author

As assisted by me and @offtherailz the remaining issue does not seem to be related to MapStore but more to how Geoserver outputs data in different CRSs intersected by the DescribeDomain operation.

@tdipisa tdipisa closed this as completed Jan 19, 2024
@tdipisa
Copy link
Member

tdipisa commented Jan 19, 2024

I'm going to close @ale-cristofori. We will reopen when/if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants