Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#10111: Enhance GeoFence attribute rule #10145

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

dsuren1
Copy link
Contributor

@dsuren1 dsuren1 commented Apr 3, 2024

Description

This PR enhances the attributes rules editor

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Enhancement

Issue

What is the current behavior?

What is the new behavior?
Allows user

  • To save all the attributes with default value (READONLY)
  • To update the specific attributes while retaining the existing changes reflective of the DB
  • Fix payload object causing failure on POST

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@dsuren1 dsuren1 added enhancement BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C040-COMUNE_GE-2023-CUSTOM-SUPPORT labels Apr 3, 2024
@dsuren1 dsuren1 added this to the 2024.01.01 milestone Apr 3, 2024
@dsuren1 dsuren1 requested a review from offtherailz April 3, 2024 05:27
@dsuren1 dsuren1 self-assigned this Apr 3, 2024
@dsuren1 dsuren1 linked an issue Apr 3, 2024 that may be closed by this pull request
1 task
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected.
Tests performed:

  • On rule creation, all the attrbutes are set to read-only, if nothing changes.
  • A second edit is persisted correctly.

@offtherailz offtherailz merged commit f108cb2 into geosolutions-it:master Apr 4, 2024
6 checks passed
@offtherailz
Copy link
Member

offtherailz commented Apr 4, 2024

@tdipisa I think next steps are backport and installation in test env c040
Testing it on mapstore dev instance is impossible because it requires the geofence stand-alone.

offtherailz pushed a commit to offtherailz/MapStore2 that referenced this pull request Apr 10, 2024
@tdipisa
Copy link
Member

tdipisa commented Apr 16, 2024

@ElenaGallo @dsuren1 this is for 2024.01.01 therefore let's wait the delivery of 2024.01.00 before backporting this. Thank you.

@ElenaGallo
Copy link
Contributor

ElenaGallo commented Apr 18, 2024

@dsuren1 @tdipisa When the user with access rule for a layer opens the attribute table, he has edit permission

How to Reproduce

  • Login as admin
  • Create this rule:
    rule
  • Create this sondaggi map
  • Login as geosolutions_test
  • Open this sondaggi map
  • Select V_SONDAGGI layer
  • Open the Attribute Table
    -> the Edit button is present on the attribute table

@tdipisa
Copy link
Member

tdipisa commented Apr 18, 2024

@ElenaGallo

@dsuren1 @tdipisa When the user with access rule for a layer opens the attribute table, he has edit permission

Why it should not be? This depends on how you decide to configure the plugin. In any case, I'm sorry but, it seems totally unrelated to the scope of this PR. Did you understand what to test here? The PR description seems quite clear to me.

@ElenaGallo
Copy link
Contributor

Test passed, @dsuren1 please backport to 2024.01.xx

@tdipisa
Copy link
Member

tdipisa commented May 14, 2024

@dsuren1 this still need to be backported for 2024.01.01

dsuren1 added a commit to dsuren1/MapStore2 that referenced this pull request May 15, 2024
tdipisa pushed a commit that referenced this pull request May 15, 2024
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance GeoFence attribute rule
4 participants