#10136: Search for Map CRS coordinates #10305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: - resolve a threshold in CRS coordinate in switch
mahmoudadel54
added
enhancement
BackportNeeded
6 tasks
dsuren1
requested changes
May 13, 2024
There was a problem hiding this comment.
@mahmoudadel54
Regression
-
Changing CRS doesn't change the X & Y accordingly, retains previous value
crs_x_y_incorrect.mp4
|
@mahmoudadel54 to clarify the purpose of this issue as per our previous exchanges in #10220, this PR should:
|
Description: - resolve not update the X/Y coods in case switch between map crs by storing the currentMapCRS into coordinate object
dsuren1
approved these changes
May 14, 2024
|
@ElenaGallo Kindly test it in DEV and let us know if it's good to be backported. Thanks |
|
Test passed, @mahmoudadel54 please backport to 2024.01.xx. Thanks |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
May 14, 2024
…t#10305) * geosolutions-it#10136: Search for Map CRS coordinates Description: - resolve a threshold in CRS coordinate in switch * geosolutions-it#10136: Search for Map CRS coordinates Description: - resolve not update the X/Y coods in case switch between map crs by storing the currentMapCRS into coordinate object
@ElenaGallo |
tdipisa
pushed a commit
that referenced
this pull request
May 14, 2024
…#10305) (#10317) * #10136: Search for Map CRS coordinates (#10220) * #10136: Search for Map CRS coordinates Description: - handle current map CRS coordinate search - Add new component for current map CRS coordinates search - create a util function for getting extent based on extent to validate the mapCRS extent in case of seach by mapCRS coords - write some unit tests accroding the new added code + changes * #10136: Search for Map CRS coordinates Description: - add translations * #10136: Search for Map CRS coordinates Description: - resolve review comments - handle projection bounds range * #10136: Search for Map CRS coordinates Description: - fix FE failure by creating a custom component for DecimalCoordinateEditorSearch * #10136: Search for Map CRS coordinates Description: - revert change in DecimalCoordinateEditor file to keep it as it is in MS * #10136: Search for Map CRS coordinates Description: - resolve review comments * #10136: Search for Map CRS coordinates Description: - resolve review comments - fix issue of not zooming to 0,0 for map crs option - don't allow to change coords inputs beyond the allowable crs extent * #10136: Search for Map CRS coordinates Description: - resolve review comments * #10136: Search for Map CRS coordinates Description: - fix clearing marker in switch to different crs * #10136: Search for Map CRS coordinates Description: - fix issue in switch to aeronautical inputs then switch to map crs coord search * #10136: Search for Map CRS coordinates Description: - resolve review comments * #10136: Search for Map CRS coordinates Description: - resolve review comments * #10136: Search for Map CRS coordinates Description: - resolve jumping cursor to last number in input number in change - Rename component to CRSCoordinateEditor * #10136: Search for Map CRS coordinates Description: - handle localization into onFocus event in CRS coordinate editor * #10136: Search for Map CRS coordinates Description: - remove util function and its test and add its logic to onFocus function directly to fix FE failure * #10136: Search for Map CRS coordinates Description: - revert changes of onFocus, onBlur for IntlNumberFormControl * #10136: Search for Map CRS coordinates Description: - fix issue in lon field * #10136: Search for Map CRS coordinates (#10305) * #10136: Search for Map CRS coordinates Description: - resolve a threshold in CRS coordinate in switch * #10136: Search for Map CRS coordinates Description: - resolve not update the X/Y coods in case switch between map crs by storing the currentMapCRS into coordinate object
tdipisa
removed
the
BackportNeeded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR: keeping user CRS coordinates X/Y as user enters in case entering them in CRS coordinate search then switches to normal coord search [lat/lon] then back again to CRS coordinates search without making change.
They are keeping as entered without a threshold.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10136
What is the current behavior?
It is mentioned at the 1st point in this comment: #10220 (comment)
What is the new behavior?
X/Y coordinates are kept as entered by the user without a threshold.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information