Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2024.01.xx] #10264: Layer visibility limits may prevent the Info panel of search results from opening (#10302, #10325) #10345

Merged

Conversation

mahmoudadel54
Copy link
Contributor

[Backport 2024.01.xx] - #10264: Layer visibility limits may prevent the Info panel of search results from opening (#10302, #10325)

mahmoudadel54 and others added 2 commits May 20, 2024 13:06
…anel of search results from opening (geosolutions-it#10302)

* geosolutions-it#10264: Layer visibility limits may prevent the Info panel of search results from opening
Description:
- isolate getFeature [identify] action from epic 'searchItemSelected' to be applied after zoom and AddMarker events by creating a new epic called 'getFeatureInfoOfSelectedItem'
- write unit test for that

* Update web/client/epics/search.js

---------

Co-authored-by: Suren <[email protected]>
…Info panel of search results from opening (geosolutions-it#10325)

* geosolutions-it#10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- edit featureInfoClick action creator by passing an optional param called 'layerWithIgnoreVisibilityLimits' to enforce it to querable layers if not exist due to visibility limits
- handle showing feature info in case of search within single layer or All layers

* geosolutions-it#10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- handle showing feature info in case of action in queryParameters

* geosolutions-it#10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- add missing check on the layer with ignoring visibility limits of making sure it is queryable
- fix FE failure test

* geosolutions-it#10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- add unit tests
- fix handling search for layers has visibility limits

* geosolutions-it#10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- fix unit test

* geosolutions-it#10264: Layer visibility limits may prevent the Info panel of search results from opening [resolve review comments]
Description:
- add reserve to querable layers in identify file to keep the same sort of toc layers in case of 'ignoreVisibilityLimits'
- edit unit test based on the change
@tdipisa tdipisa merged commit 721b6af into geosolutions-it:2024.01.xx May 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layer visibility limits may prevent the Info panel of search results from opening
2 participants