#10342: Fix issue of markers are not printed correctly #10395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description: - fix issue of now shoing marker into print
Description: - fix unit test
1 task
allyoucanmap
requested changes
Jun 5, 2024
Description: - resolve review comments by creating 'getCachedImageById' function - edit unit test
allyoucanmap
approved these changes
Jun 6, 2024
|
@ElenaGallo please test this fix on dev and let us know if we can backport on 2024.01.xx, thanks |
|
Test passed @mahmoudadel54 please backport to 2024.01.xx. Thanks |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Jun 7, 2024
Backport is done ---> #10413 |
allyoucanmap
pushed a commit
that referenced
this pull request
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, the issue of not showing markers properly in print is resolved.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10342
What is the current behavior?
#10342
What is the new behavior?
Now in print, the markers display in it normally.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
The issue was in symbolizerToPrintMSStyle where if the passed symbolizer object to 'drawWellKnownNameImageFromSymbolizer' has no radius -> it returns NaN and here:
MapStore2/web/client/utils/styleparser/PrintStyleParser.js
Line 88 in 909d495
you see the initiate values of width and height should be equal size which won't be as the returned width and height = NaN which override the symbolizer.size value
So the preproduced issue was as the icon height = NaN. not symbolizer.size