#10351: A saved map returns to the default state when the translation is changed #10405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the translation is changed Description: - fix issue of reset the map state in change locale - write unit tests
1 task
…the translation is changed Description: - revert the prev change code - handle fixing the issue by remove the key into Localized
…the translation is changed Description: - add a helpful comment in StandardRouter file
…the translation is changed Description: - change locale key prop from 'reloadOnLocaleChage' to 'localeKey' to be more meaningful
allyoucanmap
approved these changes
Jun 11, 2024
allyoucanmap
added
the
BackportNeeded
|
@ElenaGallo please test this fix on dev and let us know when we can backport to 2024.01.xx, thanks |
|
Test passed, @mahmoudadel54 please backport to 2024.01.xx, thanks |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Jun 11, 2024
…the translation is changed (geosolutions-it#10405)
@ElenaGallo |
tdipisa
removed
the
BackportNeeded
tdipisa
pushed a commit
that referenced
this pull request
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, this issue of reset map state in case of change locale [language] is resolved. It was reset map action happening due to location change due to change locale action. I added an epic to resolve this issue by checking if user open any other page rather than map viewer --> map state will be clear, else don't clear the map state.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
#10351
What is the current behavior?
#10351
What is the new behavior?
When the user changes the language of map viewer, bbox and other buttons like save/delete map will be remain as they are.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information