Updating tomcat and java versions for binary package #10446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
tdipisa
added
bug
BackportNeeded
|
Hi @tdipisa jre_11_0_22.tar.gz is available here: https://www.dropbox.com/scl/fi/87kle0o7vezax6eu18f7a/jre_11_0_22.tar.gz?rlkey=gjp6ulyos97xbf9w94xlkxg2q&st=pznxo0r2&dl=1
|
|
@randomorder thank you so much. @offtherailz keep me posted on the progress, please. |
|
Hi @randomorder the file doesn't look to be corrupted #10446 (comment) uncompress jre_11_0_22.tar.gz
gzip: jre_11_0_22.tar.gz: not in gzip format
offtherailz@tifa-nali-studio ~/Scaricati/test $ unzip jre_11_0_22.tar.gz
Archive: jre_11_0_22.tar.gz
End-of-central-directory signature not found. Either this file is not
a zipfile, or it constitutes one disk of a multi-part archive. In the
latter case the central directory and zipfile comment will be found on
the last disk(s) of this archive.
unzip: cannot find zipfile directory in one of jre_11_0_22.tar.gz or
jre_11_0_22.tar.gz.zip, and cannot find jre_11_0_22.tar.gz.ZIP, period.
(failed reverse-i-search)`tar -': unzip jre_11_0_22.^Cr.gz
offtherailz@tifa-nali-studio ~/Scaricati/test $ tar -xzvf jre_11_0_22.tar.gz
gzip: stdin: not in gzip format
tar: Child returned status 1 |
|
Hi @offtherailz |
|
Things done:
|
offtherailz
reviewed
Jul 8, 2024
binary/tomcat/conf/server.xml
Outdated
| @@ -66,27 +66,32 @@ | |||
| APR (HTTP/AJP) Connector: /docs/apr.html | |||
| Define a non-SSL/TLS HTTP/1.1 Connector on port 8080 | |||
| --> | |||
| <Connector port="8082" protocol="HTTP/1.1" | |||
| <Connector port="8080" protocol="HTTP/1.1" | |||
There was a problem hiding this comment.
Suggested change
| <Connector port="8080" protocol="HTTP/1.1" | |
| <Connector port="8082" protocol="HTTP/1.1" |
Let's not change the port used by the binary for this update.
binary/bin/mapstore2-startup.sh
Outdated
| @@ -35,6 +35,6 @@ fi | |||
| sh "$CATALINA_HOME"/bin/"$EXECUTABLE" start "$@" | |||
| echo "Waiting for Tomcat start and MapStore2 deploy..." | |||
| sleep 4 | |||
| echo "Point your browser to: http://localhost:8082/mapstore" | |||
| echo "Point your browser to: http://localhost:8080/mapstore" | |||
There was a problem hiding this comment.
Suggested change
| echo "Point your browser to: http://localhost:8080/mapstore" | |
| echo "Point your browser to: http://localhost:8082/mapstore" |
|
@ElenaGallo please check this on win once the build finish. @offtherailz then can I ask you to provide the backport please? |
|
Test passe, @offtherailz please backport to 2024.01.xx. Thanks |
offtherailz
added a commit
to offtherailz/MapStore2
that referenced
this pull request
Jul 9, 2024
…#10446) * Updating tomcat and java versions for binary package * Fixed URL and java package --------- Co-authored-by: Lorenzo Natali <[email protected]>
tdipisa
added a commit
that referenced
this pull request
Jul 9, 2024
* Updating tomcat and java versions for binary package * Fixed URL and java package --------- Co-authored-by: Tobia Di Pisa <[email protected]>
tdipisa
removed
the
BackportNeeded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the binary package to Java 11.0.22 and Tomcat 9.0.90.
Some typos have been also corrected.
The updated JRE tar.gz to be used for review is available here at the moment and it will need to be moved here (don't replace the current one) . @randomorder a new different link should be created for this so that the build of older versions can continue using the current java version.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#10444
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
@offtherailz please note that due to this 12 tomcat lib files are not included. I'm wondering if it is really wanted. The build works well and the binary generated with the following command works as expected:
@offtherailz please test also on linux using the JRE I've linked above.