Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#8334 Review mapType configuration and docs #9012

Merged
merged 5 commits into from
Mar 13, 2023

Conversation

allyoucanmap
Copy link
Contributor

Description

The PR #8990 introduced the new configuration of mapType but it does not take into account the default visualization mode that for some custom downstream project could be needed (eg initialize the app only in 3D)

New proposed configuration for mapType is:

{
  // allow to define the default visualization mode of the app and
  // which 2D or 3D map library should be used based on the device
  // the configuration below is the default one
  // note: this configuration does not support expressions
  "mapType": {
    // the default visualization mode of the app, it could be "2D" or "3D"
    "defaultVisualizationMode": "2D",
    // map library to use based on the visualization mode and device
    // structure -> { visualizationModes: { [visualizationMode]: { [deviceType]: mapLibrary } } }
    "visualizationModes": {
      "2D": {
        "desktop": "openlayers",
        "mobile": "leaflet"
      },
      "3D": {
        "desktop": "cesium",
        "mobile": "cesium"
      }
    }
  },
}

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Minor changes to existing features

Issue

What is the current behavior?

#8334

What is the new behavior?

Review of new mapType configuration

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes

Other useful information

@allyoucanmap allyoucanmap added enhancement 3D All issues related to the 3D rendering in CesiumJs C027-COMUNE_FI-2023-SUPPORT labels Mar 10, 2023
@allyoucanmap allyoucanmap added this to the 2023.02.00 milestone Mar 10, 2023
@allyoucanmap allyoucanmap self-assigned this Mar 10, 2023
@allyoucanmap allyoucanmap linked an issue Mar 10, 2023 that may be closed by this pull request
1 task
@allyoucanmap allyoucanmap linked an issue Mar 10, 2023 that may be closed by this pull request
2 tasks
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See only my comment about migration guidelines.

docs/developer-guide/mapstore-migration-guide.md Outdated Show resolved Hide resolved
@allyoucanmap allyoucanmap merged commit 736dee2 into geosolutions-it:master Mar 13, 2023
@allyoucanmap
Copy link
Contributor Author

@ElenaGallo please test this fix on dev as part of the work done in the PR #8990, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3D All issues related to the 3D rendering in CesiumJs C027-COMUNE_FI-2023-SUPPORT enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persist viewer type in the map configuration
2 participants