#9034: Fix - Spinner no longer appear when saving a resource #9044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
MV88
reviewed
Mar 29, 2023
|
|
||
| isLoading = () => { | ||
| return ( | ||
| this.props.loading || this.props.resource?.loading || this.state?.loading |
There was a problem hiding this comment.
i don't like much having three source of truth for a single loading flag...
MV88
approved these changes
Mar 29, 2023
MV88
added
the
BackportNeeded
|
@ElenaGallo testable in DEV |
|
Test passed , @dsuren1 please backport to the 2023.01.xx branch. Thanks |
dsuren1
added a commit
to dsuren1/MapStore2
that referenced
this pull request
Mar 30, 2023
…source (geosolutions-it#9044) (cherry picked from commit 278daab)
tdipisa
removed
the
BackportNeeded
tdipisa
pushed a commit
that referenced
this pull request
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the spinner when saving a resource in the save modal
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
What is the new behavior?
Screenshot
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information