Fix #9075. Handle cases when domain isnot in format start--end #9076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offtherailz
added
the
BackportNeeded
dsuren1
approved these changes
Apr 6, 2023
|
@ElenaGallo Kindly test it in Dev and let us know if it can be backported. Thanks! |
|
Going to backport it. |
|
@ElenaGallo about testing. I will take care of testing it in the project (I already did) because this bug happens in very special cases. |
offtherailz
added a commit
to offtherailz/MapStore2
that referenced
this pull request
Apr 6, 2023
…art--end (geosolutions-it#9076) * Fix geosolutions-it#9075. Handle cases when domain isnot in format start--end * Update web/client/epics/timeline.js --------- Co-authored-by: Suren <[email protected]>
tdipisa
removed
the
BackportNeeded
tdipisa
pushed a commit
that referenced
this pull request
Apr 6, 2023
#9079) * Fix #9075. Handle cases when domain isnot in format start--end * Update web/client/epics/timeline.js --------- Co-authored-by: Suren <[email protected]>
|
Test passed, @offtherailz it is possible to backport this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #9075 handling the cases when DescribeDomain does not return "start--end" format.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#9075
What is the new behavior?
Timeline do not crash. Current value is not null.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information