Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#9154 Fixed map crash when expanding timeline with time intervals #9155

Merged
merged 1 commit into from
May 17, 2023
Merged

#9154 Fixed map crash when expanding timeline with time intervals #9155

merged 1 commit into from
May 17, 2023

Conversation

offtherailz
Copy link
Member

Description

This PR fixes the issue by getting a single value from time intervals, when returned by getDomainValues

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#9154

What is the new behavior?
Fix #9154 , not crashing anymore.

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@offtherailz offtherailz added BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C044-VLAANDEREN-2023-SUPPORT labels May 11, 2023
@offtherailz offtherailz added this to the 2023.01.02 milestone May 11, 2023
@offtherailz offtherailz self-assigned this May 11, 2023
@tdipisa tdipisa requested review from MV88 and dsuren1 and removed request for MV88 May 12, 2023 10:35
dsuren1
dsuren1 approved these changes May 17, 2023
View reviewed changes
Copy link
Contributor

@dsuren1 dsuren1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dsuren1 dsuren1 merged commit 2621160 into geosolutions-it:master May 17, 2023
@dsuren1
Copy link
Contributor

dsuren1 commented May 17, 2023

@ElenaGallo Kindly test it in dev and let us know if it can be backported. Thanks!

offtherailz added a commit to offtherailz/MapStore2 that referenced this pull request May 17, 2023
@offtherailz
geosolutions-it#9154 Fixed map crash when expanding timeline with tim…
7fa3a5f 
…e intervals (geosolutions-it#9155)
@offtherailz offtherailz mentioned this pull request May 17, 2023
Merged
@offtherailz
Copy link
Member Author

I created the backport here. #9175

@ElenaGallo
Copy link
Contributor

Test passed, the backport can be merged.

dsuren1 pushed a commit that referenced this pull request May 17, 2023
@offtherailz
#9154 Fixed map crash when expanding timeline with time intervals (#9155
0756b36 
) (#9175)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsuren1 dsuren1 dsuren1 approved these changes

Assignees

@offtherailz offtherailz

Labels
BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C044-VLAANDEREN-2023-SUPPORT
Projects
None yet
Milestone
2023.01.02
Development

Successfully merging this pull request may close these issues.

timeline crashes with time intervals under certain conditions
3 participants
@offtherailz @dsuren1 @ElenaGallo