Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9176 Make Map Views tool progress bar more evident #9187

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Fix #9176 Make Map Views tool progress bar more evident #9187

merged 1 commit into from
Jun 13, 2023

Conversation

allyoucanmap
Copy link
Contributor

@allyoucanmap allyoucanmap commented May 22, 2023 •
edited
Loading

Description

This PR is including following improvements:

  • different style for active ticks
  • different color to loading bar when the play button is active
  • allow click on ticks to select a specific view
  • add tooltip with view title to each tick
progress-map-views-02.mp4

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Minor changes to existing features

Issue

What is the current behavior?

#9176

What is the new behavior?

Improved styles and interactions of the MapViews progress bar

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

Other useful information

@allyoucanmap allyoucanmap added enhancement 3D All issues related to the 3D rendering in CesiumJs labels May 22, 2023
@allyoucanmap allyoucanmap added this to the 2023.01.02 milestone May 22, 2023
@allyoucanmap allyoucanmap self-assigned this May 22, 2023
@allyoucanmap allyoucanmap linked an issue May 22, 2023 that may be closed by this pull request
Make Map Views tool progress bar more evident #9176
Closed
6 tasks
@tdipisa tdipisa requested a review from dsuren1 May 22, 2023 17:48
dsuren1
dsuren1 approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@dsuren1 dsuren1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dsuren1 dsuren1 merged commit eda4b22 into geosolutions-it:master Jun 13, 2023
@dsuren1
Copy link
Contributor

dsuren1 commented Jun 13, 2023

@ElenaGallo Please test this on dev and let us know if it can be backported to 2023.01.xx, thanks

@ElenaGallo
Copy link
Contributor

Test passed, @allyoucanmap please backport to 2023.01.xx, thanks

@allyoucanmap allyoucanmap added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jun 14, 2023
allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this pull request Jun 14, 2023
@allyoucanmap
Fix geosolutions-it#9176 Make Map Views tool progress bar more evident (
8cf2257 
geosolutions-it#9187)
@allyoucanmap allyoucanmap removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jun 14, 2023
allyoucanmap added a commit that referenced this pull request Jun 14, 2023
@allyoucanmap
Fix #9176 Make Map Views tool progress bar more evident (#9187) (#9221)
084361f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsuren1 dsuren1 dsuren1 approved these changes

Assignees

@allyoucanmap allyoucanmap

Labels
3D All issues related to the 3D rendering in CesiumJs enhancement
Projects
None yet
Milestone
2023.01.02
Development

Successfully merging this pull request may close these issues.

Make Map Views tool progress bar more evident
3 participants
@allyoucanmap @dsuren1 @ElenaGallo