Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9197 Disable apply media editor button while loading a selected item #9198

Merged
merged 1 commit into from
May 29, 2023

Conversation

allyoucanmap
Copy link
Contributor

Description

This PR adds an additional selector to disable the apply button of Media Editor while a selected item is loading

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?

#9197

What is the new behavior?

The apply button is disabled when a resource is loading

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • No

Other useful information

@allyoucanmap allyoucanmap self-assigned this May 29, 2023
@allyoucanmap allyoucanmap linked an issue May 29, 2023 that may be closed by this pull request
1 task
@allyoucanmap allyoucanmap added this to the 2023.01.02 milestone May 29, 2023
@allyoucanmap allyoucanmap added bug geonode_integration BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch labels May 29, 2023
@tdipisa tdipisa requested a review from offtherailz May 29, 2023 09:38
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can not test now but the code looks ok.

@allyoucanmap allyoucanmap merged commit cd0197b into geosolutions-it:master May 29, 2023
@allyoucanmap
Copy link
Contributor Author

@ElenaGallo please test if everything is still working as expected on MapStore with the media editor, I'll make a backport on geonode branch so we can test it also there

allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this pull request May 29, 2023
allyoucanmap added a commit to allyoucanmap/MapStore2 that referenced this pull request May 29, 2023
@allyoucanmap allyoucanmap removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label May 29, 2023
@ElenaGallo
Copy link
Contributor

@allyoucanmap test passed on DEV MS. Please backport to the stable branch, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable apply media editor button while loading a selected item
3 participants