Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9139: Fix - New WFS layers no longer visible in dashboards #9230

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

dsuren1
Copy link
Contributor

@dsuren1 dsuren1 commented Jun 16, 2023

Description

This PR fixes the following

  • Zoom to layer is not enabled on WFS layer
  • DescribeLayer call on WFS service layer

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix

Issue

What is the current behavior?

What is the new behavior?

  • User can zoom in on WFS layer added
  • Skip addSearch WFS when layer is selected

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@dsuren1 dsuren1 added this to the 2023.01.02 milestone Jun 16, 2023
@dsuren1 dsuren1 requested a review from offtherailz June 16, 2023 13:59
@dsuren1 dsuren1 self-assigned this Jun 16, 2023
@dsuren1 dsuren1 linked an issue Jun 16, 2023 that may be closed by this pull request
1 task
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

  • Issue with CQL_FILTER has been solved in #8990
  • The bbox now works

For this PR everything looks good. 👍
I noticed the default style of WFS layer in dashboard and on map are different. @tdipisa is there an issue for it?

@offtherailz offtherailz merged commit 3af3f96 into geosolutions-it:master Jun 16, 2023
@tdipisa
Copy link
Member

tdipisa commented Jun 16, 2023

For this PR everything looks good. 👍 I noticed the default style of WFS layer in dashboard and on map are different. @tdipisa is there an issue for it?

No as far as this PR is concerned, I think. We can consider to open a dedicated issue for that @offtherailz.

@tdipisa
Copy link
Member

tdipisa commented Jun 16, 2023

@ElenaGallo please test in DEV and let @dsuren1 know if he can backport

@offtherailz
Copy link
Member

For this PR everything looks good. +1 I noticed the default style of WFS layer in dashboard and on map are different. @tdipisa is there an issue for it?

No as far as this PR is concerned, I think. We can consider to open a dedicated issue for that @offtherailz.

Here the issue #9232

@ElenaGallo
Copy link
Contributor

Test passed, @dsuren1 please backport to the stable branch. Thanks

@ElenaGallo ElenaGallo added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jun 19, 2023
dsuren1 added a commit to dsuren1/MapStore2 that referenced this pull request Jun 19, 2023
offtherailz pushed a commit that referenced this pull request Jun 19, 2023
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New WFS layers no longer visible in dashboards
4 participants