#9263 geoprocessing tools #9316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
offtherailz
requested changes
Aug 3, 2023
There was a problem hiding this comment.
- I wasn't able to perform intersection
- If I select a raster as source (maybe I shouldn't for certain processes) and i try to select a feature, it gives me successful notification
select_feature_raster_gpt.webm
- If I select a vector layer (e.g. on of the ones generated by 'buffer') I've got this error in console.
geoProcessingTools.js:140 TypeError: Cannot read properties of undefined (reading 'protocol')
at isURLSameOrigin (isURLSameOrigin.js:57:24)
at dispatchXhrRequest (xhr.js:145:50)
at new Promise (<anonymous>)
at xhrAdapter (xhr.js:15:10)
at dispatchRequest (dispatchRequest.js:58:10)
- Sometimes under certain selections, run do not re-enable after errors.
gpt_error_run.webm
- I wasn't able to perform one intersection that works. How to do it?
@MV88 Please do a quick check of the files before to submit the review. Some of the wrong commit content can be identified quiclky by you, but it may be difficoult for the reviewer, and some may not be so clear that are not needed.
| @@ -55,6 +55,20 @@ export const updateOptionsByOwner = (owner, options) => { | |||
| options | |||
| }; | |||
| }; | |||
| /** | |||
| * merge options of additional layers selected by owner | |||
There was a problem hiding this comment.
mergeOptionsByOwner is a little obscure as usage and name. The action looks to update every additional layer with the same owner. like updateOptionsByOwner.
I think this should be implementaed as an option of updateOptionsByOwner.
Add a 3rd optional argument to updateOptionsByOwner, named mode. By default it is 'override'. (similar to the actionType of other actions here). Other option is merge. If merge, it will merge the existing options. if override it will work as it works now.
Correct me if I'm wrong.
There was a problem hiding this comment.
you should check the implementation of updateOptionsByOwner,
mergeOptionsByOwner goes in override and not in replace
I can refactor it if you want, but i feel it is more clear to use a different action
too many parameters and multi purpose function complicates things as well
Comment on lines
3909
to
3913
| "warningTitle": "Warning", | ||
| "warningBody": "You have not selected a feature and this may slow down performances in geoserver. Do you want to continue?", | ||
| "warningConfirmText": "Yes", | ||
| "warningCancel": "Cancel", |
There was a problem hiding this comment.
yes in ConfirmModal of Main comp
There was a problem hiding this comment.
I mean they are not tooltips, they are texts for buttons, title and body of a modal, but they are under "tooltips": section of the json.
There was a problem hiding this comment.
i missed this. going to fix it
37 tasks
6 tasks
wps_intersection_log_error.log This is caused by an issue in fetching the feature collection of the highroad which is a big MultiLineString here is a request to test it over gs-stable @tdipisa will this need a JIRA? all the rest is addressed or there is response in the comment |
|
@offtherailz to test intersection you can add this data attached to a postgis JNDI layer to the geoserver. CREATE TABLE
global_polygons
(
id SERIAL NOT NULL,
NAME CHARACTER VARYING(64),
the_geom geography,
PRIMARY KEY (id)
);
INSERT INTO global_polygons (id, name, the_geom) VALUES (1, 'test polygon', '0103000020E61000000100000005000000805FC9B96FAFF93F6427F84321024740805FC9B96FAFF93F5419470E8FCF4540D04562E3829B23405419470E8FCF4540D04562E3829B23406427F84321024740805FC9B96FAFF93F6427F84321024740');
INSERT INTO global_polygons (id, name, the_geom) VALUES (2, 'small polygon', '0103000020E6100000010000000500000080D36B9B5AFA2440948BFE78CE46464060A577E8C7AD1140948BFE78CE46464060A577E8C7AD1140802EC1510123464080D36B9B5AFA2440802EC1510123464080D36B9B5AFA2440948BFE78CE464640');
|
@MV88 gs-stable follows regularly the GS release workflow, that means it will be updated to a new GS stable version as soon as it is available. In the meantime we can test with our gs-main. |
offtherailz
reviewed
Aug 9, 2023
I agree @MV88, that's usually important to manage. The pagination is better. |
@tdipisa @offtherailz consider that when i pick the feature clicking on map it must be part of the list, additionally we repopulate the list if the user has cleared selection demo.using.pagination.and.select.features.mp4 |
offtherailz
reviewed
Aug 11, 2023
offtherailz
reviewed
Aug 11, 2023
offtherailz
reviewed
Aug 11, 2023
offtherailz
reviewed
Aug 11, 2023
offtherailz
reviewed
Aug 11, 2023
offtherailz
reviewed
Aug 11, 2023
offtherailz
reviewed
Aug 11, 2023
offtherailz
approved these changes
Aug 11, 2023
|
@ElenaGallo please test in DEV |
ElenaGallo
added
the
BackportNeeded
|
@MV88 please backport this to the stable branch. Thanks |
tdipisa
removed
the
BackportNeeded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this PR implements the buffer and intersection tool. for more details see the issue
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
What is the new behavior?
see issue description for more details
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
Testing information
It have to be tested against gs-main because of this #9316 (comment)