#9352 Add new drawing/modify interaction component supports #9353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allyoucanmap
added
annotations
3 tasks
offtherailz
requested changes
Sep 5, 2023
web/client/components/map/cesium/__tests__/DrawGeometrySupport-test.jsx
Outdated
Show resolved
Hide resolved
| * @prop {function} onEditEnd triggered one the editing has been completed | ||
| * @prop {function} toEditProperties convert properties of feature to edit properties geometryType, geodesic and radius are needed to compute the editing. geometryType could be: Point, LineString, Polygon or Circle | ||
| * @prop {function} fromEditProperties restore properties of the feature to the original one | ||
| * @prop {number} mouseMoveThrottleTime throttle value to limit the mousemove event callback and improve the interaction, default 100ms |
There was a problem hiding this comment.
- The default has been removed. Is it still valid as 100ms? Does it make sense to expose it? It is specific only of cesium.
There was a problem hiding this comment.
I removed it from the props so it's not exposed and 100ms by default
Comment on lines
147
to
150
| this._fromEditProperties = options.fromEditProperties ? options.fromEditProperties : (editProperties, feature) => ({ | ||
| ...feature?.properties, | ||
| ...(editProperties?.radius !== undefined && { radius: editProperties.radius }) | ||
| }); |
There was a problem hiding this comment.
Move this in common between functions as default
| @@ -7,6 +7,7 @@ | |||
| */ | |||
|
|
|||
| import * as Cesium from 'cesium'; | |||
| import earcut from 'earcut'; | |||
There was a problem hiding this comment.
Is this lib included? I can not see it package.json
There was a problem hiding this comment.
@offtherailz I think it's included by cesium, if you want I can add it in the package.json?
Co-authored-by: Lorenzo Natali <[email protected]>
…-test.jsx Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
Co-authored-by: Lorenzo Natali <[email protected]>
offtherailz
reviewed
Sep 5, 2023
offtherailz
reviewed
Sep 5, 2023
offtherailz
reviewed
Sep 5, 2023
offtherailz
reviewed
Sep 5, 2023
offtherailz
reviewed
Sep 5, 2023
…into issue_9352
offtherailz
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements draw and modify components that could be used for Cesium and OpenLayers. This new components will be used inside the refactor of Annotations
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#9352
What is the new behavior?
Introduced drawing and modify support for Cesium and a new components for OpenLayers
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information