Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #9071 add advanced options to counter widgets #9536

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Oct 2, 2023

Description

adding advanced options to counter
image

NOTE I'm including d3-format because formatting the number value with Formatted number of react-intl is not the same

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

fix #9071

What is the new behavior?

for counter widgets now it's possible to define:

  • prefix
  • suffix
  • format
  • formula

note the old field uom is removed in favor of suffix, and this requires user guide update

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

tester can import this dashboard that had uom configured as states, after renaming it as .json
dashboard.txt

@MV88 MV88 added this to the 2024.01.00 milestone Oct 2, 2023
@MV88 MV88 requested a review from offtherailz October 2, 2023 17:04
@MV88 MV88 self-assigned this Oct 2, 2023
@tdipisa tdipisa requested review from dsuren1 and removed request for offtherailz October 3, 2023 08:14
@MV88 MV88 changed the title fix #9071 add advanced options to coutner widgets fix #9071 add advanced options to counter widgets Oct 4, 2023
Copy link
Contributor

@dsuren1 dsuren1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dsuren1 dsuren1 merged commit 2e09d7f into geosolutions-it:master Oct 5, 2023
6 checks passed
@dsuren1
Copy link
Contributor

dsuren1 commented Oct 5, 2023

@ElenaGallo Kindly test it in dev once deployed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Format and Formula support for counter widget
2 participants