Fix #9575 Avoid full rerender in filterRenderer #9577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsuren1
requested changes
Oct 11, 2023
There was a problem hiding this comment.
@offtherailz
The fix works fine. But it introduces a new issue where the filter row is hidden on first load of feature grid. Kindly check if this is happening. Thanks!
Screen.Recording.2023-10-11.at.4.47.23.PM.mov
|
Thank you @dsuren1 , I didn't noticed it. |
offtherailz
commented
Oct 11, 2023
web/client/plugins/featuregrid/__tests__/FeatureEditor-test.jsx
Outdated
Show resolved
Hide resolved
offtherailz
commented
Oct 11, 2023
dsuren1
approved these changes
Oct 12, 2023
offtherailz
added a commit
to offtherailz/MapStore2
that referenced
this pull request
Oct 12, 2023
…lutions-it#9577) * Fix geosolutions-it#9575 Avoid full rerender in filterRenderer * Fixed wrong usage of usememo * Update web/client/plugins/featuregrid/__tests__/FeatureEditor-test.jsx * Update web/client/plugins/featuregrid/FeatureEditor.jsx * Update FeatureEditor.jsx
dsuren1
pushed a commit
that referenced
this pull request
Oct 12, 2023
* Fix #9575 Avoid full rerender in filterRenderer * Fixed wrong usage of usememo * Update web/client/plugins/featuregrid/__tests__/FeatureEditor-test.jsx * Update web/client/plugins/featuregrid/FeatureEditor.jsx * Update FeatureEditor.jsx
|
@ElenaGallo please test in DEV and QA |
|
Test passed on DEV, @offtherailz please backport to the stable branch. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue happens when fields is not defined. In selector the "[]" was regenerated everytime.
I fixed the selector and added an additional security in featureEditor to avoid regeneration of filterRenderers (and so loss of focus) when the values are equal.
This guarantees that if the feature grid receives them dynamically for some reason, the filter renderers are not re-computed.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#9575
What is the new behavior?
Fix #9575
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information