Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9617 legends with percent for pie chart #9618

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Fix #9617 legends with percent for pie chart #9618

merged 4 commits into from
Oct 19, 2023

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Oct 17, 2023 •
edited
Loading

Description

image

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

Fix #9617

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@MV88 MV88 added this to the 2023.02.01 milestone Oct 17, 2023
@MV88 MV88 requested a review from offtherailz October 17, 2023 14:41
@MV88 MV88 self-assigned this Oct 17, 2023
@MV88 MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 17, 2023
offtherailz
offtherailz approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@offtherailz offtherailz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • values in labels are wrong (0.10% instead of 10%)
  • in hover template the value looks duplicated.

image

I sent some corrections and added the proper unit test.
So now it is mergiable to me.
Please take a look to my changes.

@MV88 MV88 merged commit e50eecd into geosolutions-it:master Oct 19, 2023
6 checks passed
@MV88
Copy link
Contributor Author

MV88 commented Oct 19, 2023

@ElenaGallo please test DEV

@tdipisa tdipisa modified the milestones: 2023.02.01, 2024.01.00 Oct 19, 2023
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@offtherailz offtherailz offtherailz approved these changes

Assignees

@MV88 MV88

Labels
C027-COMUNE_FI-2023-SUPPORT enhancement
Projects
None yet
Milestone
2024.01.00
Development

Successfully merging this pull request may close these issues.

Widgets - make Pie charts with many entries to be able to clearly see percent from legend
3 participants
@MV88 @offtherailz @tdipisa