Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #9638 ui issue with context when adding all plugins #9639

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

MV88
Copy link
Contributor

@MV88 MV88 commented Oct 20, 2023

Description

fixed the issues in the contexts

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Issue

What is the current behavior?

#9638

What is the new behavior?

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@MV88 MV88 added this to the 2023.02.01 milestone Oct 20, 2023
@MV88 MV88 requested a review from offtherailz October 20, 2023 15:57
@MV88 MV88 self-assigned this Oct 20, 2023
@MV88 MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 23, 2023
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This menu is not so visible
image

So I pushed some changes to make it look like this:

image

From my testings now it works well. Please double check you too @MV88

@offtherailz offtherailz self-requested a review October 23, 2023 16:34
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • with #/context/Longitudinal_profile
    the overflow is now broken:

image

Previous implementation worked correctly:
image

  • I fixed the menu style. Anyway when you close the burger menu, the popup stays open. We have to hide it.
  • Fix useEffect

@MV88 MV88 requested a review from offtherailz October 23, 2023 20:28
Copy link
Member

@offtherailz offtherailz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplified logic behind menu

web/client/plugins/longitudinalProfile/Menu.jsx Outdated Show resolved Hide resolved
@MV88 MV88 merged commit 99c69da into geosolutions-it:master Oct 24, 2023
6 checks passed
@MV88
Copy link
Contributor Author

MV88 commented Oct 24, 2023

@ElenaGallo please test it in DEV

MV88 added a commit to MV88/MapStore2 that referenced this pull request Oct 24, 2023
geosolutions-it#9639)

* Fix geosolutions-it#9638 ui issue with context when adding all plugins

* Fixed the menu to be visible.

* Fix behaviour in every case

* Simplified logic behind menu

---------

Co-authored-by: Lorenzo Natali <[email protected]>
@MV88 MV88 removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 24, 2023
@ElenaGallo ElenaGallo added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 24, 2023
@ElenaGallo
Copy link
Contributor

Test passed, @tdipisa it is possible to marge the backport #9652

MV88 added a commit that referenced this pull request Oct 24, 2023
* Fix #9638 ui issue with context when adding all plugins

* Fixed the menu to be visible.

* Fix behaviour in every case

* Simplified logic behind menu

---------

Co-authored-by: Lorenzo Natali <[email protected]>
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding GeoProcessing and LongitudinalProfileTool plugins in a context will cause UI issue
4 participants