Fix #9814 Further issue with visibility limits in master #9817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allyoucanmap
added
bug
3D
1 task
dsuren1
approved these changes
Dec 14, 2023
|
@ElenaGallo Kindly test this fix in DEV. Thanks! |
ElenaGallo
added
the
BackportNeeded
|
Test passed, @allyoucanmap please backport to 2023.02.xx. Thanks! |
allyoucanmap
added a commit
to allyoucanmap/MapStore2
that referenced
this pull request
Dec 15, 2023
allyoucanmap
removed
the
BackportNeeded
tdipisa
pushed a commit
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts the formula introduced in #9777 to compute the zoom level because it is not reliable. The formula needs the globe ready and in some cases it's not at the initialization of a map viewer causing a computation of the zoom with the old formula as fallback. The difference between the new and old formula results increases when the camera is tilted as in the described scenario in the issue.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#9814
What is the new behavior?
Revert computation of zoom level in cesium implementation
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information