Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#9586 - Persist timeline animation settings when saving a map #9865

Merged
merged 1 commit into from
Jan 11, 2024
Merged

#9586 - Persist timeline animation settings when saving a map #9865

merged 1 commit into from
Jan 11, 2024

Conversation

dsuren1
Copy link
Contributor

@dsuren1 dsuren1 commented Jan 10, 2024

Description

This PR saves the playback timeline settings when saving a map and initializes the playback data on map config load

Please check if the PR fulfills these requirements

What kind of change does this PR introduce? (check one with "x", remove the others)

  • Enhancement

Issue

What is the current behavior?

What is the new behavior?

  • Persist timeline settings by saving the data on map save
  • Initializes the playback data on map config load

Breaking change

Does this PR introduce a breaking change? (check one with "x", remove the other)

  • Yes, and I documented them in migration notes
  • No

Other useful information

@dsuren1 dsuren1 added enhancement Support Timeline BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch C027-COMUNE_FI-2023-SUPPORT labels Jan 10, 2024
@dsuren1 dsuren1 added this to the 2023.02.02 milestone Jan 10, 2024
@dsuren1 dsuren1 self-assigned this Jan 10, 2024
@dsuren1 dsuren1 linked an issue Jan 10, 2024 that may be closed by this pull request
Persist timeline animation settings when saving a map #9586
Closed
6 tasks
@tdipisa tdipisa requested review from MV88 and removed request for offtherailz January 10, 2024 14:00
MV88
MV88 approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@MV88 MV88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MV88 MV88 merged commit 254dcc2 into geosolutions-it:master Jan 11, 2024
6 checks passed
@MV88
Copy link
Contributor

MV88 commented Jan 11, 2024

@ElenaGallo Please test it in DEV

@tdipisa
Copy link
Member

tdipisa commented Jan 11, 2024

@ElenaGallo let us know for the backport

@ElenaGallo
Copy link
Contributor

Test passed, @dsuren1 please backport to 2023.02.xx. Thanks

dsuren1 added a commit to dsuren1/MapStore2 that referenced this pull request Jan 12, 2024
@dsuren1
geosolutions-it#9586 - Persist timeline animation settings when savin…
cd3f6b5 
…g a map (geosolutions-it#9865)

(cherry picked from commit 254dcc2)
@dsuren1 dsuren1 mentioned this pull request Jan 12, 2024
Merged
tdipisa pushed a commit that referenced this pull request Jan 12, 2024
@dsuren1
#9586 - Persist timeline animation settings when saving a map (#9865) (…
f017346 
…#9875)

(cherry picked from commit 254dcc2)
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MV88 MV88 MV88 approved these changes

Assignees

@dsuren1 dsuren1

Labels
C027-COMUNE_FI-2023-SUPPORT enhancement Support Timeline
Projects
None yet
Milestone
2023.02.02
Development

Successfully merging this pull request may close these issues.

Persist timeline animation settings when saving a map
4 participants
@dsuren1 @MV88 @tdipisa @ElenaGallo