Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle partial downloads #944

Closed
dustinbyrne opened this issue Apr 16, 2024 · 1 comment · Fixed by #953
Closed

Handle partial downloads #944

dustinbyrne opened this issue Apr 16, 2024 · 1 comment · Fixed by #953
Assignees
@dividedmind
Labels
bug Something isn't working released

Comments

@dustinbyrne
Copy link
Contributor

dustinbyrne commented Apr 16, 2024 •
edited
Loading

Partial downloads are problematic in that they:

  • will not be detected
  • won't be retried
  • will have a symlink pointed at them upon restarting the editor

There are a few ways to solve this:

  • downloads can be verified via sha sum upon initialization
  • partial downloads are not written to their final destination on disk until the download has completed
    • this should force downloads to restart if the window was closed before a download completed
@dustinbyrne dustinbyrne added the bug Something isn't working label Apr 16, 2024
dividedmind added a commit that referenced this issue Apr 26, 2024
@dividedmind
fix: Retry downloads when needed, show progress and allow cancellation
1d64223 
Fixes #944
@dividedmind dividedmind mentioned this issue Apr 26, 2024
Merged
dustinbyrne pushed a commit that referenced this issue Apr 30, 2024
@dividedmind @dustinbyrne
fix: Retry downloads when needed, show progress and allow cancellation
3b303aa 
Fixes #944
appland-release added a commit that referenced this issue Apr 30, 2024
@appland-release
chore(release): 0.118.1 [skip ci]
e8d27c5 
## [0.118.1](v0.118.0...v0.118.1) (2024-04-30)

### Bug Fixes

* Don't replace tool symlinks when not required ([9838923](9838923))
* Fix a case where the RPC port would not properly assign after ([43e2795](43e2795))
* Retry downloads when needed, show progress and allow cancellation ([3b303aa](3b303aa)), closes [#944](#944)
@appland-release
Copy link
Contributor

🎉 This issue has been resolved in version 0.118.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dividedmind dividedmind

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Retry downloads when needed, show progress and allow cancellation getappmap/vscode-appland
3 participants
@dividedmind @dustinbyrne @appland-release