feat: add command to install appmap agent #467
Conversation
ahtrotta
force-pushed
the
add-command-to-install-appmap-agent
branch
from
194a64a
to
8829a07
Compare
src/extension.ts
Outdated
| await workspaceServices.enroll(processService); | ||
| })(); | ||
| processService.onReady(activateUptodateService); | ||
| await processService.install(); |
There was a problem hiding this comment.
Awaiting an install here may take a significant amount of time depending on the users connection/platform. The problem with this is that any initialization logic below this will be blocked until the installation completes. In the previous implementation the installation and enrollment is done without awaiting the result, allowing the rest of the initialization to continue on.
There was a problem hiding this comment.
I was thinking that if we didn't block the rest of the initialization logic, then the user might try to press the automated install button before the installAgent command gets created and then it would fail. Do you think that's a problem?
dustinbyrne
force-pushed
the
add-command-to-install-appmap-agent
branch
2 times, most recently
from
2b050dc
to
b395a6d
Compare
# [0.45.0](v0.44.1...v0.45.0) (2022-10-06) ### Bug Fixes * Fix crash on undefined object ([a0e7c41](a0e7c41)) * Fix multi-line processing of uptodate output ([ba42826](ba42826)) ### Features * Add command to install appmap agent ([#467](#467)) ([b5e0933](b5e0933)) * Authenticate with AppMap Server ([ac971f3](ac971f3)) * manage AppMap Server configuration ([f08b5e6](f08b5e6))
|
🎉 This PR is included in version 0.45.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Fixes applandinc/board#161