Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why testing 'page.header.continue_link' before including comments plugin #45

Closed
pamtbaau opened this issue Jul 20, 2018 · 2 comments
Closed

Comments

@pamtbaau
Copy link

Quark (and Enigma) have the following code in 'partials/blog-item.html.twig'

{% if page.header.continue_link is sameas(true) and config.plugins.comments.enabled %}
   {% include 'partials/comments.html.twig' %}
{% endif %}

What purpose serves testing 'page.header.continue_link' before adding the comments plugin needed?

I cannot find any documentation on the use of 'continue_link' both here as on 'learn'

@pamtbaau pamtbaau changed the title Why test for 'page.header.continue_link' before adding the comments plugin Why test 'page.header.continue_link' before including comments plugin Jul 20, 2018
@pamtbaau pamtbaau changed the title Why test 'page.header.continue_link' before including comments plugin Why testing 'page.header.continue_link' before including comments plugin Jul 20, 2018
@rhukster
Copy link
Member

Seems this was a missing option in blog item blueprint. I've added it now.

@pamtbaau
Copy link
Author

pamtbaau commented Dec 13, 2019

@rhukster Comming back to this issue because a user is stumbling over the problem that the Comments plugin is not included in blog items...

Again, why is page.header.continue_link is same as(true) used to test if the Comments plugin should be included or not. The value is only of any value in 'templates/partials/blog/title.html.twig'.

The consequence of the test is that the Comments form will no be added to the blog items unless the user adds 'continue_link: true' explicitly to every blog item, or overrides the template in a inherited theme.

It also lacks any documentation.

As a side question: What is the 'Daring Fireball style title link'? Google doesn't return any link looking like the one that is created when link and continue_link are set in frontmatter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants