Adds support for UsePreviousTemplate to create_change_set #8229
Conversation
Adds missing support for using the UsePreviousTemplate param with UsePreviousValue in the parameter list with calling the cloudformation create_change_set method. Adds unit tests. Code clean-up.
jamaalscarlett
force-pushed
the
add_prev_value_support_to_create_change_set
branch
from
a5b5802
to
935b7e9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8229 +/- ##
==========================================
+ Coverage 94.53% 94.54% +0.01%
==========================================
Files 1157 1158 +1
Lines 99973 100124 +151
==========================================
+ Hits 94513 94667 +154
+ Misses 5460 5457 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Hi @jamaalscarlett, thank you for the PR! Looks good overall, just some minor nitpicks.
| param["parameter_key"]: param["parameter_value"] | ||
| param["parameter_key"]: stack.parameters[param["parameter_key"]] | ||
| if param.get("use_previous_value", "").lower() == "true" | ||
| and use_previous_template |
There was a problem hiding this comment.
I've extracted this variable outside of the if-statement above so that it's always available - not just when updating a changeset. Otherewise there is a situation where Python would throw a variable not declared error.
| @@ -1568,18 +1568,18 @@ def test_describe_change_set(stack_template, change_template): | |||
| ChangeSetType="CREATE", | |||
| ) | |||
|
|
|||
| stack = cf.describe_change_set(ChangeSetName="NewChangeSet") | |||
| change_set = cf.describe_change_set(ChangeSetName="NewChangeSet") | |||
There was a problem hiding this comment.
Nice! Always good to have proper naming
Co-authored-by: Bert Blommers <[email protected]>
|
@bblommers Thanks for the review, I think I've addressed everything. |
Adds missing support for using the UsePreviousTemplate param with UsePreviousValue in the parameter list with calling the cloudformation create_change_set method.
Adds unit tests.
Code clean-up.