Add SHA1 and SHA256 algorithms for EC2 fingerprint calculation #8235
+48
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8235 +/- ##
=======================================
Coverage 94.54% 94.55%
=======================================
Files 1158 1158
Lines 100124 100129 +5
=======================================
+ Hits 94667 94672 +5
Misses 5457 5457
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bblommers
requested changes
Oct 18, 2024
There was a problem hiding this comment.
Hi @nifadyev, thank you for the PR! I just have a nitpick on the naming.
@viren-nadkarni Do you want to review this as well?
| # TODO: Use different fingerprint calculation methods based on key type and source | ||
| # see https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/verify-keys.html#how-ec2-key-fingerprints-are-calculated | ||
| def public_key_fingerprint( | ||
| public_key: Union[RSAPublicKey, Ed25519PublicKey], is_created: bool = False |
There was a problem hiding this comment.
The naming of is_created is a bit confusing for people without any context. Any objections to rename this to something like use_sha1: bool?
A comment in the caller function (random_rsa_key_pair) can then explain why we're using sha1:
# This fingerprint should use sha1 because it's created by EC2
# See https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/verify-keys.html#how-ec2-key-fingerprints-are-calculated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves localstack issue
@viren-nadkarni is recommended to make changes in
motoin this comment