-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to build 4.24.1 engine with plugin #184
Comments
If you're using git, you may need to pull with --recurse-submodules to pull the third-party sources (if you're using the releases, use the .7z not sources which will also correctly contain submodules sources). Otherwise the marketplace 4.24 version is currently submitted pending approval. |
I'm using release archive which unpak to the ue-source\Engine\Plugins\Marketplace\SocketIOClient folder. As I can see archive contain all submodules. |
I tried sources and pak with binaries (*.7z) and the result is the same. |
I've run into the same issue when trying to cook / package the client as a standalone. The problem is the use of This is the offending line: https:/getnamo/socketio-client-ue4/blob/f682bcc51a16343f7200bad541353f1878c076eb/SocketIOClient.uplugin#L77 |
That makes sense. With 4.24 the developer category was removed and I thought developer tool was the correct context for that one, but it seems editor is the correct upgrade path. Thanks @marwanhilmi for spotting the fix! Fix added: 089e8d9, repull master or get the latest release: https:/getnamo/socketio-client-ue4/releases/tag/1.3.2 |
Spotted by @marwanhilmi #184 (comment)
@marwanhilmi Thanks a lot. @getnamo The latest release is built without errors. |
Plugin sources placed into ue-source\Engine\Plugins\Marketplace\SocketIOClient
The text was updated successfully, but these errors were encountered: