Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build 4.24.1 engine with plugin #184

Closed
dazre opened this issue Dec 25, 2019 · 6 comments
Closed

Unable to build 4.24.1 engine with plugin #184

dazre opened this issue Dec 25, 2019 · 6 comments

Comments

@dazre
Copy link

dazre commented Dec 25, 2019

Plugin sources placed into ue-source\Engine\Plugins\Marketplace\SocketIOClient

1>Invalidating makefile for UE4Server (SocketIOClient.uplugin has been added)
1>D:\UnrealEngine-4.24.1-release\Engine\Plugins\Marketplace\SocketIOClient\Source\SocketIOLib\SocketIOLib.Build.cs : warning : Referenced directory 'D:\UnrealEngine-4.24.1-release\Engine\Plugins\Marketplace\SocketIOClient\Source\ThirdParty\asio\asio\include' does not exist.
1>D:\UnrealEngine-4.24.1-release\Engine\Plugins\Marketplace\SocketIOClient\Source\SocketIOLib\SocketIOLib.Build.cs : warning : Referenced directory 'D:\UnrealEngine-4.24.1-release\Engine\Plugins\Marketplace\SocketIOClient\Source\ThirdParty\rapidjson\include' does not exist.
1>UnrealBuildTool : error : Unable to instantiate module 'UnrealEd': Unable to instantiate UnrealEd module for non-editor targets.
1>                        (referenced via Target -> SIOJEditorPlugin.Build.cs -> AssetTools.Build.cs)
@getnamo
Copy link
Owner

getnamo commented Dec 26, 2019

If you're using git, you may need to pull with --recurse-submodules to pull the third-party sources (if you're using the releases, use the .7z not sources which will also correctly contain submodules sources). Otherwise the marketplace 4.24 version is currently submitted pending approval.

@dazre
Copy link
Author

dazre commented Dec 26, 2019

I'm using release archive which unpak to the ue-source\Engine\Plugins\Marketplace\SocketIOClient folder. As I can see archive contain all submodules.

@dazre
Copy link
Author

dazre commented Dec 26, 2019

I tried sources and pak with binaries (*.7z) and the result is the same.

@marwanhilmi
Copy link

I've run into the same issue when trying to cook / package the client as a standalone. The problem is the use of DeveloperTool in the .uplugin definition. Can't find any documentation on why / how this has changed but the correct value should be Editor. Switching to Editor works. Had the same issue with our own plugins.

This is the offending line: https:/getnamo/socketio-client-ue4/blob/f682bcc51a16343f7200bad541353f1878c076eb/SocketIOClient.uplugin#L77

@getnamo
Copy link
Owner

getnamo commented Dec 27, 2019

That makes sense. With 4.24 the developer category was removed and I thought developer tool was the correct context for that one, but it seems editor is the correct upgrade path. Thanks @marwanhilmi for spotting the fix!

Fix added: 089e8d9, repull master or get the latest release: https:/getnamo/socketio-client-ue4/releases/tag/1.3.2

@dazre
Copy link
Author

dazre commented Dec 29, 2019

@marwanhilmi Thanks a lot. @getnamo The latest release is built without errors.

@getnamo getnamo closed this as completed Dec 31, 2019
johsuacarter added a commit to johsuacarter/Unity-Game-Socket-IOClient-Unreal that referenced this issue Sep 5, 2022
bradleythomas1223 added a commit to bradleythomas1223/Unreal-Socket-IO-Client that referenced this issue Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants