Add 5G buffer to space required for postgres upgrade #429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #424
What has been done to verify that this works as intended?
On the dev server, I changed the line changed by this PR to
used="$(( $(du -s /var/lib/docker | cut -f1) + 5000000" )) # add 5G of buffer
There's about 11G of stuff in that folder and I confirmed that the script said I needed 17G for the update.
I don't have a good strategy for requesting the space check when the migration has already been done (and there's no
postgres
container). I think this is good enough but the reviewer should see whether they agree!Why is this the best possible solution? Were any other approaches considered?
I considered telling the user we were adding a buffer or only adding it in the error message. But this is simple and feels like the most fool-proof.
The issue mentioned the possibility of 10Gb of buffer. That seemed extreme to me.
I'm not totally sure whether the arithmetic expansion is necessary (it worked for me without) but I figure it can't hurt.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Risk is isolated to space determination. It might be broken.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No.
Before submitting this PR, please make sure you have: