Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Answers to required questions are gone when finalize form #4566

Closed
kkrawczyk123 opened this issue May 17, 2021 · 3 comments
Closed

Answers to required questions are gone when finalize form #4566

kkrawczyk123 opened this issue May 17, 2021 · 3 comments

Comments

@kkrawczyk123
Copy link
Contributor

Software and hardware versions

Collect v1.30.x, Android v probably all, device used...

Problem description

When testing Central, I have noticed that some of the added answers in the form are gone when trying to edit on Central. I investigated and it turned out that they are gone when finalizing form on Collect so it's not a Central issue.
Form that I have used: https://test.getodk.cloud/#/projects/307/forms/elqas_v1
elqas_v1.xlsx

ezgif com-gif-maker (1)

Steps to reproduce the problem

  1. Download form to Collect
  2. Fill the submission, all required questions
  3. Finalize form
  4. Open Edit Saved form and see that previously added answers are gone: question "Name of locality" for all repeats.

Expected behavior

Answers to required questions should not be cleared when finalizing the form.

Other information

I haven't noticed such an issue when using other forms with required questions.

@lognaturel
Copy link
Member

This form misuses calculates in an attempt to have dynamic defaults. On finalize, the value of house_locality_name is always set to the value of locality. locality is not required (weird) and I see in your video that you didn't give it a value. That means the value of house_locality_name for every repeat instance is always cleared on save. More in this recent forum thread.

CC @yanokwa who might know where this form came from (eLQAS v1). Would be good to let folks know about this mistake if the form is still in use/published. CC also @grzesiek2010 so you can see in action why I really wanted to add to that forum thread.

@lognaturel
Copy link
Member

Although this is mostly a form design issue, there is something weird about the order of evaluations and checks on form finalization that would be good to investigate at some point. I've filed getodk/javarosa#633.

@yanokwa
Copy link
Member

yanokwa commented May 19, 2021

The form is published at https:/polio/elqas but I don't know anyone using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants