Add multi-argument and single string distance variants #761
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #740
Adds multiple arguments as described at getodk/xforms-spec#311
What has been done to verify that this works as intended?
Added a tests, tried sample form in Collect.
Why is this the best possible solution? Were any other approaches considered?
See getodk/xforms-spec#311 for spec consideration.
I went back and forth on where to include the logic around argument quantity and types. I decided to put it in
XPathFuncExpr
because that's most inline with what other functions do and it feels helpful to get an overview of variants at that top level.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Regression risks center around the existing distance function. It's possible the changes break that existing variant in some subtle way.
Do we need any specific form for testing your changes? If so, please attach one.
https://docs.google.com/spreadsheets/d/1Dv9lD33Bfqz4XqmTNMJXm4NK9Lw0TloKph1juU0Kins/edit#gid=1068911091
Does this change require updates to documentation? If so, please file an issue here and include the link below.
getodk/docs#1795