Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor @getodk/webform 2/2 #193

Open
3 tasks
sadiqkhoja opened this issue Aug 22, 2024 · 0 comments
Open
3 tasks

Refactor @getodk/webform 2/2 #193

sadiqkhoja opened this issue Aug 22, 2024 · 0 comments

Comments

@sadiqkhoja
Copy link
Contributor

sadiqkhoja commented Aug 22, 2024

From #164 (comment)

  • When using provide/inject, would be nice to establish a pattern where they use normal references so the connection between provided/injected state can be followed in editor, and types can be defined in provide. I did a quick spike on this not long ago and it seemed possible, happy to dig up the stash if there’s interest.
  • Events make me nervous for reasons similar to provide/inject. They seem a bit easier to follow at component boundaries, but the lack of clear types with a single source of truth is still concerning.
  • The tooling boundary between .vue and .ts modules is a continuing headache. Common case: TS/ESLint differing on whether a type is any. Case that stood out here: props interface exported from component, referenced in test. Would like to consider other approaches that minimize this. And/or set aside some time to see if any tooling updates address these shortcomings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

1 participant