Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: client reactivity of translated select item labels #114

Merged
merged 5 commits into from
May 15, 2024
Merged

Fix: client reactivity of translated select item labels #114

merged 5 commits into from
May 15, 2024

Commits on May 11, 2024

  1. Test: client reactivity of SelectItem labels

    @eyelidlessness
    eyelidlessness committed May 11, 2024
    Configuration menu
    Copy the full SHA
    a8d99e7 View commit details
    Browse the repository at this point in the history

  2. Fix: client reactivity for translated <itemset> labels

    @eyelidlessness
    eyelidlessness committed May 11, 2024
    Configuration menu
    Copy the full SHA
    a2dcdac View commit details
    Browse the repository at this point in the history

  3. Fix: client reactivity of translated <item> labels

    @eyelidlessness
    eyelidlessness committed May 11, 2024
    Configuration menu
    Copy the full SHA
    4168680 View commit details
    Browse the repository at this point in the history

  4. Run all CI jobs 

    Several jobs which would potentially be affected by the engine changes on this branch are not being run, because they don’t check for engine changes.

This may be temporary, but it’s the simplest/quickest naive solution.
    @eyelidlessness
    eyelidlessness committed May 11, 2024
    Configuration menu
    Copy the full SHA
    43da993 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. Move scope.runTask down the stack in select item reactivity 

    Per discussion of keeping/extending local reasoning about reactive scope.
    @eyelidlessness
    eyelidlessness committed May 15, 2024
    Configuration menu
    Copy the full SHA
    93217c0 View commit details
    Browse the repository at this point in the history