parse and report async gaps #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't crashy able to tell us if this fixes things? :) |
|
This PR does not fix missing async stack traces. It only fixes missing async gaps, should they appear in the stack. I just confirmed using crashy that release builds are indeed missing async stack traces. Will comment in the original issue. |
cbracken
approved these changes
Aug 7, 2017
lib/src/stack_trace.dart
Outdated
| frames.addAll(chain.traces[t].frames.map(encodeStackTraceFrame)); | ||
| if (t < chain.traces.length - 1) { | ||
| frames.add(asynchronousGapFrameJson); | ||
| } |
There was a problem hiding this comment.
Drop the curly brackets for one-line ifs.
| : new Chain.parse(stackTrace); | ||
|
|
||
| final List<Map<String, dynamic>> frames = <Map<String, dynamic>>[]; | ||
| for (int t = 0; t < chain.traces.length; t += 1) { |
There was a problem hiding this comment.
That's Flutter style.
|
|
ueman
pushed a commit
that referenced
this pull request
Jul 19, 2021
Update isolate_error_integration.dart
This was referenced Dec 24, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: flutter/flutter#11479